New issue
Advanced search Search tips

Issue 662497 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: surface perf violations in console

Project Member Reported by pfeldman@chromium.org, Nov 4 2016

Issue description

That'd be opt-in checkbox in the console.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bf066cc7d7529342fd260e5bf3d98a97c6b133f

commit 8bf066cc7d7529342fd260e5bf3d98a97c6b133f
Author: pfeldman <pfeldman@chromium.org>
Date: Mon Nov 07 23:34:45 2016

DevTools: add the logging aspect into the PerformanceMonitor, plumb it over the remote debugging protocol, surface it in DevTools. Also adds proof of concept violation reporting for layout thrashing and long running tasks.

BUG= 662497 

Review-Url: https://codereview.chromium.org/2474073005
Cr-Commit-Position: refs/heads/master@{#430418}

[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/LayoutTests/inspector/input-event-warning.html
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/frame/Settings.in
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/ConsoleTypes.h
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/InspectorLogAgent.h
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/main/module.json
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js
[modify] https://crrev.com/8bf066cc7d7529342fd260e5bf3d98a97c6b133f/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b951047a98329d8b1d8be534db6a763e280db291

commit b951047a98329d8b1d8be534db6a763e280db291
Author: pfeldman <pfeldman@chromium.org>
Date: Sat Nov 12 01:12:25 2016

Convert performance monitor to the subscription model.

BUG= 662497 

Review-Url: https://codereview.chromium.org/2484213003
Cr-Commit-Position: refs/heads/master@{#431719}

[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/LayoutTests/inspector/input-event-warning.html
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/inspector/InspectorLogAgent.h
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/timing/Performance.h
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/core/timing/PerformanceTest.cpp
[modify] https://crrev.com/b951047a98329d8b1d8be534db6a763e280db291/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6

commit 2f106eacd201e3dbe2e1df77c44793bc4d0a9de6
Author: pfeldman <pfeldman@chromium.org>
Date: Thu Nov 17 05:46:42 2016

DevTools: introduce perf monitor actions w/ time budget for violations that are event handlers.

BUG= 662497 

Review-Url: https://codereview.chromium.org/2513483002
Cr-Commit-Position: refs/heads/master@{#432771}

[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.cpp
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/bindings/core/v8/ScriptEventListener.h
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/core/frame/PerformanceMonitor.h
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/2f106eacd201e3dbe2e1df77c44793bc4d0a9de6/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7b02cfa0c763063d9cf8afded60ee434f92c19

commit cc7b02cfa0c763063d9cf8afded60ee434f92c19
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Nov 18 04:10:20 2016

DevTools: support all handlers that end up with function call in perfmonitor.

BUG= 662497 

Review-Url: https://codereview.chromium.org/2514643002
Cr-Commit-Position: refs/heads/master@{#433087}

[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/cc7b02cfa0c763063d9cf8afded60ee434f92c19/third_party/WebKit/Source/core/frame/PerformanceMonitor.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c5acf32c515709bb28f067d3540e5a0ddde6547

commit 5c5acf32c515709bb28f067d3540e5a0ddde6547
Author: pfeldman <pfeldman@chromium.org>
Date: Tue Nov 22 02:38:06 2016

DevTools: bring violations and timeline warnings in sync.

BUG= 662497 

Review-Url: https://codereview.chromium.org/2515693003
Cr-Commit-Position: refs/heads/master@{#433752}

[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/LayoutTests/http/tests/inspector/forced-layout-in-microtask-expected.txt
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-expected.txt
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-recalculate-styles-expected.txt
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback-expected.txt
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/Source/core/inspector/InspectorLogAgent.h
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js
[modify] https://crrev.com/5c5acf32c515709bb28f067d3540e5a0ddde6547/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Status: Fixed (was: Assigned)

Sign in to add a comment