New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662493 link

Starred by 2 users
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 614588



Sign in to add a comment

[Content settings] adding session only exception adds exception to the blocked list

Project Member Reported by dschuyler@chromium.org, Nov 4 2016 
in chrome://md-settings/content/location we have blocked, session only, and allowed lists. Adding a site to session only puts the site exception in the blocked list.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbefa1097f65603c4832c44b1a12cb419016d1e5

commit dbefa1097f65603c4832c44b1a12cb419016d1e5
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Nov 11 01:46:18 2016

[MD settings] show blocked sites even when category is blocked

This CL removes the logic that sometimes hides the blocked or session
only lists, so that they are now always shown. This is a desired UI
change from Alan.

BUG= 662491 ,  662493 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2468363005
Cr-Commit-Position: refs/heads/master@{#431449}

[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/dbefa1097f65603c4832c44b1a12cb419016d1e5/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

Comment 2 by dschuyler@chromium.org, Nov 11 2016

Status: Fixed (was: Started)
►

Sign in to add a comment