New issue
Advanced search Search tips

Issue 662488 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Defer DRP UI initialization

Project Member Reported by ryansturm@chromium.org, Nov 4 2016

Issue description

When DRP is initializaed in ProfileImplIOData::Handle::Init, it gets the URLRequestContextGetter for the profile, which will start off posts to the IO thread. This initialization can be deferred until the main request context is created. It will allow ProfileImplIOData::Handle::Init to complete before ProfileImplIOData::InitializeInternal starts. Since they both touch the same objects but on different threads this will be a better guarantee of thread safety at initialization. Currently, only io_data_->previews_io_data_ is set on the UI thread here after the IO thread can start running ProfileImplIOData::InitializeInternal.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff0a4a3f4f165290c3da7902a67d98434a49e7e3

commit ff0a4a3f4f165290c3da7902a67d98434a49e7e3
Author: ryansturm <ryansturm@chromium.org>
Date: Tue Nov 08 19:06:18 2016

Defer DRP start up until after the context getter is created

DRP initialization will be defered until the main request context is
created. Currently, DRP will force the create of the context getter
causing unneccesary early evaluation.

BUG= 662488 

Review-Url: https://codereview.chromium.org/2475143002
Cr-Commit-Position: refs/heads/master@{#430676}

[modify] https://crrev.com/ff0a4a3f4f165290c3da7902a67d98434a49e7e3/chrome/browser/profiles/profile_impl_io_data.cc

Status: Fixed (was: Started)

Sign in to add a comment