New issue
Advanced search Search tips

Issue 662477 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

imported/wpt/html/webappapis/scripting/events/onerroreventhandler.html marked as "Leak"

Project Member Reported by se...@chromium.org, Nov 4 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Linux Precise Leak

Type: build-failure

Builders failed on: 
- WebKit Linux Precise Leak: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak




 
Labels: Pri-2 Type-Bug
Next step: add the test which has the leak issue to the LeakExpectations file.
Note: changes to add:

These can fail rather than timeout:

imported/wpt/html/browsers/the-window-object/window-open-noopener.html
imported/wpt/html/webappapis/idle-callbacks/callback-exception.html
imported/wpt/html/webappapis/idle-callbacks/callback-iframe.html
imported/wpt/html/webappapis/idle-callbacks/callback-invoked.html
imported/wpt/html/webappapis/idle-callbacks/callback-multiple-calls.html
imported/wpt/html/webappapis/idle-callbacks/callback-timeout.html

This should be skipped for the leak bots until fixed upstream:

imported/wpt/html/webappapis/idle-callbacks/cancel-invoked.html
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4581f89f3fc1368fd343ca2062218f7b0bfc7b

commit bf4581f89f3fc1368fd343ca2062218f7b0bfc7b
Author: qyearsley <qyearsley@chromium.org>
Date: Sat Nov 05 18:44:57 2016

Add imported/wpt/html/webappapis/idle-callbacks/cancel-invoked.html to LeakExpectations

This test has the following leak log:

({"numberOfLiveActiveDOMObjects":[2,3]})

Example results:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_Leak/1493/layout-test-results/results.html

BUG=662477

Review-Url: https://codereview.chromium.org/2480973002
Cr-Commit-Position: refs/heads/master@{#430173}

[modify] https://crrev.com/bf4581f89f3fc1368fd343ca2062218f7b0bfc7b/third_party/WebKit/LayoutTests/LeakExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e61ea18e80725cbb3e86719aaf390feb1788c6c9

commit e61ea18e80725cbb3e86719aaf390feb1788c6c9
Author: tasak <tasak@google.com>
Date: Wed Nov 09 12:37:42 2016

Mark imported/wpt/html/webappapis/scripting/events/onerroreventhandler.html as Leak

BUG=662477
TBR=scheib

Review-Url: https://codereview.chromium.org/2484223003
Cr-Commit-Position: refs/heads/master@{#430916}

[modify] https://crrev.com/e61ea18e80725cbb3e86719aaf390feb1788c6c9/third_party/WebKit/LayoutTests/LeakExpectations

Comment 6 by vabr@chromium.org, Nov 9 2016

Cc: haraken@chromium.org
 Issue 663719  has been merged into this issue.
Components: Tests
Labels: -Pri-2 -Hotlist-SheriffBot Test-Layout Pri-3
Summary: imported/wpt/html/webappapis/scripting/events/onerroreventhandler.html marked as "Leak" (was: webkit_tests failing on chromium.webkit/WebKit Linux Precise Leak)
Note: Possibly related to bug 501866?
Labels: OS-Linux
Owner: ----
Status: Available (was: Assigned)
It looks like imported/wpt/html/webappapis/idle-callbacks/cancel-invoked.html is timed out before leaking.
Sorry but external/wpt/html/webappapis/idle-callbacks/cancel-invoked.html
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/479085f864f815a6378913310125b26456c7bc6e

commit 479085f864f815a6378913310125b26456c7bc6e
Author: Hajime Hoshi <hajimehoshi@chromium.org>
Date: Tue Aug 01 13:11:50 2017

Remove timed-out test from LeakExpectation

The test is now timed out on the flakiness dashboard because idle tasks
are never called on tests until testRunner.runIdleTasks explcitly
( crbug.com/595152 ). This doesn't leak now.

This CL also fixes a comment regarding  crbug.com/726218 .

Bug:  595152 , 662477
Change-Id: I757bd5e72063933b28d92dc69cb4a3e42e9e4c56
Reviewed-on: https://chromium-review.googlesource.com/595792
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490959}
[modify] https://crrev.com/479085f864f815a6378913310125b26456c7bc6e/third_party/WebKit/LayoutTests/LeakExpectations

Project Member

Comment 13 by sheriffbot@chromium.org, Aug 1

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment