Instead of a self.mock, could we just use the mock framework?

Why we need run_test.py as a separate unittest runner? Can we just fit in the infra testing setup?

could we just use the mock framework?

2) It's easy to implement the self.mock function as in production code.
1) I want those tests in util_scripts/ be similar to other unittest to be consistent. This is just the way other tests are using.
3) There are already many unittests rewritten in self.mock format, this way can save time and effort in a clean way. :)

Why we need run_test.py as a separate unittest runner? Can we just fit in the infra testing setup?
Yes, we can use a hack in __init__.py to fit in the infra testing setup.

> 1) I want those tests in util_scripts/ be similar to other unittest to be consistent.

FWIW, I've been trying to get rid of the use of self.mock in the unittests, because it makes the tests extremely fragile and very difficult to debug. So trying to match the current unittests isn't a good motivation.

But it is the infra repo convention, isn't it?
What's your plan to get rid of it?

In lots of places, it's sufficient to create (sub)classes which mock out the relevant methods.

I'm not saying we should jump through hoops to get rid of every single use of self.mock; there are some places where self.mock is the most straightforward approach. But we want our tests to be robust against changes in the underlying code. The more that tests depend on the guts of an implementation (which using self.mock almost invariably does), the more fragile they are. Whereas the more that tests depend only on the arguments and results of functions, the easier it is to change around the implementation of those functions without causing the tests to crash or spuriously fail.

We are moving to unittest.mock wherever possible; the self.mock is not the best approach although it is helpful in some cases.

katesonia@:
I cced you quite a while on this CL https://codereview.chromium.org/2158533002/
I guessed you just skip those CLs I cced you :)

stgao@, right, I missed that... closed this issue.