Version Google Chrome Framework / Chromium Framework |
|||||||||
Issue descriptionWe want to use XPC Services from within the Chromium Framework in order to support native notifications. Based on my findings in https://docs.google.com/document/d/1h7eNZbdFyrM6r6taJxHuW-GQm34FJSFqmfwZkEj3eAA/edit, the Framework needs to be versioned. Currently we do not version the framework, so the contents are in Chromium Framework.framework/XPCServices. But they need to be in Chromium Framework.framework/Versions/Current/XPCServices for launchd to locate them. When we specify the framework_version on //chrome:chrome_framework, we need to make sure nothing about the official build process breaks. This includes: making sure that the build gets signed correctly, that the diff updater produces a good diff, that it gets applied correctly in Chrome (specifically watch the symlinks), and that the resulting binary still has a good code signature. For good measure, that'd all happen for two consecutive builds.
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5669b7c1dd94fad2dfc33974a6c91e4a899dbade commit 5669b7c1dd94fad2dfc33974a6c91e4a899dbade Author: rsesek <rsesek@chromium.org> Date: Thu Nov 10 18:15:26 2016 [Mac/GN] Create symlinks for every item //chrome:chrome_framework when versioned. BUG= 662466 Review-Url: https://codereview.chromium.org/2490253002 Cr-Commit-Position: refs/heads/master@{#431292} [modify] https://crrev.com/5669b7c1dd94fad2dfc33974a6c91e4a899dbade/chrome/BUILD.gn
,
Nov 10 2016
,
Nov 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67b763d98a68f492757edf29814c5e385ad5db5d commit 67b763d98a68f492757edf29814c5e385ad5db5d Author: rsesek <rsesek@chromium.org> Date: Sun Nov 13 23:16:10 2016 [Mac/GN] Fix //chrome:chrome_dump_syms and :chrome_dsym_archive when the framework is versioned. BUG= 662466 R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2495883002 Cr-Commit-Position: refs/heads/master@{#431812} [modify] https://crrev.com/67b763d98a68f492757edf29814c5e385ad5db5d/chrome/BUILD.gn
,
Nov 14 2016
,
Nov 18 2016
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a1ebea8a247366ac822858e141983037a1f0059 commit 5a1ebea8a247366ac822858e141983037a1f0059 Author: rsesek <rsesek@chromium.org> Date: Thu Feb 02 14:10:03 2017 [Mac] Version the //chrome:chrome_framework bundle. BUG= 604809 , 662466 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2484283003 Cr-Commit-Position: refs/heads/master@{#447763} [modify] https://crrev.com/5a1ebea8a247366ac822858e141983037a1f0059/chrome/BUILD.gn
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35483db6126d73c64f467503ece03c6a119d0a68 commit 35483db6126d73c64f467503ece03c6a119d0a68 Author: Robert Sesek <rsesek@chromium.org> Date: Thu Feb 02 15:30:39 2017 [Merge to 2998 for test build] [Mac] Version the //chrome:chrome_framework bundle. BUG= 604809 , 662466 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2484283003 Cr-Commit-Position: refs/heads/master@{#447763} (cherry picked from commit 5a1ebea8a247366ac822858e141983037a1f0059) Review-Url: https://codereview.chromium.org/2676593003 . Cr-Commit-Position: refs/branch-heads/2998@{#5} Cr-Branched-From: 2a9afa9fbfc5d76d668f3aeb70894f83d4686886-refs/heads/master@{#447146} [modify] https://crrev.com/35483db6126d73c64f467503ece03c6a119d0a68/chrome/BUILD.gn
,
Feb 2 2017
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d46123678f9f8e22c6210134bdbcfdb3e49b3bf2 commit d46123678f9f8e22c6210134bdbcfdb3e49b3bf2 Author: rsesek <rsesek@chromium.org> Date: Thu Feb 02 19:26:21 2017 Revert of [Mac] Version the //chrome:chrome_framework bundle. (patchset #1 id:1 of https://codereview.chromium.org/2484283003/ ) Reason for revert: Failed to sign in the official test build on 2998 (see https://crbug.com/688076). Original issue's description: > [Mac] Version the //chrome:chrome_framework bundle. > > BUG= 604809 , 662466 > TBR=dpranke@chromium.org > > Review-Url: https://codereview.chromium.org/2484283003 > Cr-Commit-Position: refs/heads/master@{#447763} > Committed: https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e141983037a1f0059 TBR=miguelg@google.com,miguelg@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 604809 , 662466 Review-Url: https://codereview.chromium.org/2669213003 Cr-Commit-Position: refs/heads/master@{#447816} [modify] https://crrev.com/d46123678f9f8e22c6210134bdbcfdb3e49b3bf2/chrome/BUILD.gn
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66d62f64ba8e8b3408211546710dce9cb4f6545b commit 66d62f64ba8e8b3408211546710dce9cb4f6545b Author: Robert Sesek <rsesek@chromium.org> Date: Thu Feb 16 20:01:20 2017 [Merge to 3012 for test build] [Mac] Version the //chrome:chrome_framework bundle. BUG= 604809 , 662466 TBR=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2484283003 Cr-Commit-Position: refs/heads/master@{#447763} (cherry picked from commit 5a1ebea8a247366ac822858e141983037a1f0059) Review-Url: https://codereview.chromium.org/2703653002 . Cr-Commit-Position: refs/branch-heads/3012@{#10} Cr-Branched-From: 66847e854d3acd13965764bcbc72d38f455c463c-refs/heads/master@{#450199} [modify] https://crrev.com/66d62f64ba8e8b3408211546710dce9cb4f6545b/chrome/BUILD.gn
,
Feb 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/247dfa7270288b09ff4ff433e616408102b51755 commit 247dfa7270288b09ff4ff433e616408102b51755 Author: rsesek <rsesek@chromium.org> Date: Fri Feb 17 02:07:45 2017 Reland of [Mac] Version the //chrome:chrome_framework bundle. (patchset #1 id:1 of https://codereview.chromium.org/2669213003/ ) Reason for revert: Test build on 3012 passed. Original issue's description: > Revert of [Mac] Version the //chrome:chrome_framework bundle. (patchset #1 id:1 of https://codereview.chromium.org/2484283003/ ) > > Reason for revert: > Failed to sign in the official test build on 2998 (see https://crbug.com/688076). > > Original issue's description: > > [Mac] Version the //chrome:chrome_framework bundle. > > > > BUG= 604809 , 662466 > > TBR=dpranke@chromium.org > > > > Review-Url: https://codereview.chromium.org/2484283003 > > Cr-Commit-Position: refs/heads/master@{#447763} > > Committed: https://chromium.googlesource.com/chromium/src/+/5a1ebea8a247366ac822858e141983037a1f0059 > > TBR=miguelg@google.com,miguelg@chromium.org,dpranke@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= 604809 , 662466 > > Review-Url: https://codereview.chromium.org/2669213003 > Cr-Commit-Position: refs/heads/master@{#447816} > Committed: https://chromium.googlesource.com/chromium/src/+/d46123678f9f8e22c6210134bdbcfdb3e49b3bf2 TBR=miguelg@google.com,miguelg@chromium.org,dpranke@chromium.org NOTRY=true BUG= 604809 , 662466 Review-Url: https://codereview.chromium.org/2700013002 Cr-Commit-Position: refs/heads/master@{#451175} [modify] https://crrev.com/247dfa7270288b09ff4ff433e616408102b51755/chrome/BUILD.gn
,
Feb 17 2017
This should be done.
rsesek@hotwire:/Users/rsesek % tree -I Resources /Applications/Google\ Chrome\ Canary.app
/Applications/Google\ Chrome\ Canary.app
└── Contents
├── Info.plist
├── MacOS
│ └── Google\ Chrome\ Canary
├── PkgInfo
├── Versions
│ ├── 58.0.3014.0
│ │ ├── Google\ Chrome\ Framework.framework
│ │ │ ├── Default\ Apps
│ │ │ │ ├── docs.crx
│ │ │ │ ├── drive.crx
│ │ │ │ ├── external_extensions.json
│ │ │ │ ├── gmail.crx
│ │ │ │ └── youtube.crx
│ │ │ ├── Frameworks
│ │ │ │ └── KeystoneRegistration.framework
│ │ │ │ ├── Headers
│ │ │ │ │ ├── KSRegistration.h
│ │ │ │ │ ├── KSRegistrationErrors.h
│ │ │ │ │ └── KSReportingAttribute.h
│ │ │ │ ├── KeystoneRegistration
│ │ │ │ └── _CodeSignature
│ │ │ │ └── CodeResources
│ │ │ ├── Google\ Chrome\ Framework
│ │ │ ├── Helpers
│ │ │ │ └── crashpad_handler
│ │ │ ├── Internet\ Plug-Ins
│ │ │ │ └── nacl_irt_x86_64.nexe
│ │ │ ├── Libraries
│ │ │ │ └── WidevineCdm
│ │ │ │ ├── _platform_specific
│ │ │ │ │ └── mac_x64
│ │ │ │ │ ├── libwidevinecdm.dylib
│ │ │ │ │ └── widevinecdmadapter.plugin
│ │ │ │ └── manifest.json
│ │ │ └── _CodeSignature
│ │ │ └── CodeResources
│ │ └── Google\ Chrome\ Helper.app
│ │ └── Contents
│ │ ├── Info.plist
│ │ ├── MacOS
│ │ │ └── Google\ Chrome\ Helper
│ │ ├── PkgInfo
│ │ └── _CodeSignature
│ │ └── CodeResources
│ └── 58.0.3015.0
│ ├── Google\ Chrome\ Framework.framework
│ │ ├── Default\ Apps -> Versions/Current/Default\ Apps
│ │ ├── Frameworks -> Versions/Current/Frameworks
│ │ ├── Google\ Chrome\ Framework -> Versions/Current/Google\ Chrome\ Framework
│ │ ├── Helpers -> Versions/Current/Helpers
│ │ ├── Internet\ Plug-Ins -> Versions/Current/Internet\ Plug-Ins
│ │ ├── Libraries -> Versions/Current/Libraries
│ │ └── Versions
│ │ ├── A
│ │ │ ├── Default\ Apps
│ │ │ │ ├── docs.crx
│ │ │ │ ├── drive.crx
│ │ │ │ ├── external_extensions.json
│ │ │ │ ├── gmail.crx
│ │ │ │ └── youtube.crx
│ │ │ ├── Frameworks
│ │ │ │ └── KeystoneRegistration.framework
│ │ │ │ ├── Headers
│ │ │ │ │ ├── KSRegistration.h
│ │ │ │ │ ├── KSRegistrationErrors.h
│ │ │ │ │ └── KSReportingAttribute.h
│ │ │ │ ├── KeystoneRegistration
│ │ │ │ └── _CodeSignature
│ │ │ │ └── CodeResources
│ │ │ ├── Google\ Chrome\ Framework
│ │ │ ├── Helpers
│ │ │ │ └── crashpad_handler
│ │ │ ├── Internet\ Plug-Ins
│ │ │ │ └── nacl_irt_x86_64.nexe
│ │ │ ├── Libraries
│ │ │ │ └── WidevineCdm
│ │ │ │ ├── _platform_specific
│ │ │ │ │ └── mac_x64
│ │ │ │ │ ├── libwidevinecdm.dylib
│ │ │ │ │ └── widevinecdmadapter.plugin
│ │ │ │ └── manifest.json
│ │ │ └── _CodeSignature
│ │ │ └── CodeResources
│ │ └── Current -> A
│ └── Google\ Chrome\ Helper.app
│ └── Contents
│ ├── Info.plist
│ ├── MacOS
│ │ └── Google\ Chrome\ Helper
│ ├── PkgInfo
│ └── _CodeSignature
│ └── CodeResources
└── _CodeSignature
└── CodeResources
,
Feb 17 2017
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91bfdf3e5fd8b4403f1a346552c0ad991c52913d commit 91bfdf3e5fd8b4403f1a346552c0ad991c52913d Author: rsesek <rsesek@chromium.org> Date: Sat Feb 18 07:37:12 2017 [Mac] Fix crashpad_handler @rpath in the component build. After versioning the framework in 247dfa7270288b09ff4ff433e616408102b51755b, crashpad_handler would fail to start in a component build with this error: dyld: Library not loaded: @rpath/libbase.dylib Referenced from: /Volumes/Build/src/out/debug/Chromium.app/Contents/Versions/58.0.3016.0/Chromium Framework.framework/Helpers/crashpad_handler Reason: image not found BUG= 693721 , 662466 R=mark@chromium.org Review-Url: https://codereview.chromium.org/2704763002 Cr-Commit-Position: refs/heads/master@{#451441} [modify] https://crrev.com/91bfdf3e5fd8b4403f1a346552c0ad991c52913d/build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn
,
Mar 16 2017
Could the document be made public accessible? Thanks in advance. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by miguelg@chromium.org
, Nov 7 2016Labels: -Type-Bug Type-Feature
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)