New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662445 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Cells won't update once Sync to a new account is completed.

Project Member Reported by sczs@chromium.org, Nov 4 2016

Issue description

After Syncing to a new account on Settings>Account>Sync the Sync cell changes its detail text to "Sync in Progress" and the Account cell on Settings changes it detail text to "Sync Off".

This is expected since the App is syncing to the new account. The problem is that once the Sync is complete these 2 cells won't update its detail text content unless we close and reopen Settings. 
 
Cc: -sczs@chromium.org
Owner: sczs@chromium.org
Status: Assigned (was: Untriaged)
Note: I haven't been able to reproduce this issue locally (after syncing to head). Sergio, am I missing some context?

I'm pretty sure it was working before the screens were migrated to MDC. If it stopped working, we must have missed something during the migration.

Comment 2 by sczs@chromium.org, Nov 7 2016

Hi, Benoit,

I just reproduced this before any of the screens involved were migrated to MDC after syncing to 150248051029de42a29c808011ffabdf77dd4cf5. I was also able to reproduce and after syncing to head. (I used an iPhone 7 simulator, but I'm pretty sure this happened on iPhone 6 as well)

You need to have at least 2 accounts linked to chrome. After that go to Settings>Account>Sync and pick an account you are not currently syncing 

Once you have switched to the different account go back one screen to Settings>Account  and you will see 1st.png, which is expected.

If you go back to Settings "root" screen you'll see 2nd.png.

If you access the Account again you'll see 3rd.png (there's no sync icon). 

All these cells will display this same information unless you completely reopen Settings. I was able to reproduce this before any of the screens involved were migrated to MDC.  

Not sure how the Signing/Syncing process works, but it would appear that is not informing the observers to update the cells? WDYT?


1st.png
13.8 KB View Download
2nd.png
28.6 KB View Download
3rd.png
12.5 KB View Download
Cc: -bzanotti@chromium.org sczs@chromium.org
Owner: bzanotti@chromium.org
It is expected for "Setup in progress..." to be shown until the user has closed the Settings after switching the sync account. This is to give time to the user to configure its sync preferences.

I see two small issues that I'll fix:
- The sync image that disappeared in Account Settings.
- Text should be "Setup in progress..." instead of "Sync is Off" in that specific case in the Main Settings.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/c395dbd73e1799415f2a49dae614a24347c469a6

commit c395dbd73e1799415f2a49dae614a24347c469a6
Author: bzanotti <bzanotti@google.com>
Date: Tue Nov 08 10:57:44 2016

Status: Fixed (was: Assigned)

Sign in to add a comment