Currently the Web Bluetooth chooser on Chrome apps on non-Mac machine shows some artifacts, see the screenshot attached. Need to fix it to be the same as the chooser shown on Chrome browser.
Here are some screenshots.
Screenshot when calling: DialogDelegate::CreateNonClientFrameView https://cs.chromium.org/chromium/src/ui/views/window/dialog_delegate.cc?sq=package:chromium&l=192
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04 commit 3e540deecddbbdc2f857bba72f0fc19bdd4b3f04 Author: juncai <juncai@chromium.org> Date: Thu Nov 10 01:02:59 2016 Fix the Web Bluetooth chooser when it is used on Chrome apps on non-Mac This CL adds code to override the views::DialogDelegate::CreateClientView() and views::DialogDelegate::CreateNonClientFrameView() to fix the artifacts on the Web Bluetooth chooser when it is used on Chrome apps on non-Mac. I uploaded some screenshots on the issue page. BUG= 662444 Review-Url: https://codereview.chromium.org/2478863003 Cr-Commit-Position: refs/heads/master@{#431120} [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/chooser_content_view.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/chooser_content_view.h [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/chooser_content_view_unittest.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/extensions/chooser_dialog_view.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/extensions/chooser_dialog_view.h [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/ui/views/window/dialog_delegate.cc [modify] https://crrev.com/3e540deecddbbdc2f857bba72f0fc19bdd4b3f04/ui/views/window/dialog_delegate.h
Comment 1 by juncai@chromium.org
, Nov 4 2016