New issue
Advanced search Search tips

Issue 662431 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

WTF/std normalization

Project Member Reported by pilgrim@chromium.org, Nov 4 2016

Issue description

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9e1380ae7c169501892b25f1ee82e04207e9208

commit c9e1380ae7c169501892b25f1ee82e04207e9208
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Nov 04 17:22:48 2016

WTF/std normalization: replace WTF::Vector::removeLast with ::pop_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces removeLast() with pop_back(). There are no
functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2459003003
Cr-Commit-Position: refs/heads/master@{#429930}

[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/ContextMenu.h
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/ContiguousContainerTest.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/PathTraversalState.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208/third_party/WebKit/Source/wtf/Vector.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8523015364743073bb38eb30bc389c2437904ba8

commit 8523015364743073bb38eb30bc389c2437904ba8
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Nov 17 14:57:38 2016

WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces emplaceAppend() with emplace_back(). There are no
functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2457163002
Cr-Commit-Position: refs/heads/master@{#432875}

[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/core/layout/ng/ng_inline_box_test.cc
[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc
[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/8523015364743073bb38eb30bc389c2437904ba8/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2eeebca35376f259f684fc32c89dc2f52a8047

commit 6f2eeebca35376f259f684fc32c89dc2f52a8047
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Nov 18 15:53:48 2016

WTF/std normalization: replace WTF::Vector::last with ::back

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces last() with back(). There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2502413004
Cr-Commit-Position: refs/heads/master@{#433209}

[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/SelectorFilter.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/css/resolver/MatchResult.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/shadow/DistributedNodes.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/events/EventListenerMap.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/HTMLSlotElement.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/TimeRanges.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/style/QuotesData.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/svg/SVGEnumeration.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/PODArena.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/SharedBuffer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/blob/BlobData.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/fonts/GlyphBuffer.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/geometry/Region.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/Gradient.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/PathTraversalState.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/paint/PaintChunker.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/network/EncodedFormData.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/plugins/PluginListBuilder.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/text/BidiContext.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/platform/text/LocaleWin.cpp
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/6f2eeebca35376f259f684fc32c89dc2f52a8047/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5fbce5b84544a61512d2eaf6e2e743dc22b164b

commit e5fbce5b84544a61512d2eaf6e2e743dc22b164b
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Nov 29 00:06:02 2016

WTF/std normalization: replace WTF::Vector::first() with ::front()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces first() with front(). There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2470233009
Cr-Commit-Position: refs/heads/master@{#434784}

[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/mojo/public/cpp/bindings/wtf_array.h
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/css/MediaQueryExp.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/dom/shadow/DistributedNodes.h
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/html/HTMLSlotElement.h
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/html/TimeRanges.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/vr/VRPose.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/vr/VRStageParameters.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/platform/audio/AudioDSPKernelProcessor.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/platform/audio/Reverb.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/wtf/HashMapTest.cpp
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/e5fbce5b84544a61512d2eaf6e2e743dc22b164b/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdbfb17f86fe5080e59821de6b352b74044a044a

commit fdbfb17f86fe5080e59821de6b352b74044a044a
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Dec 07 21:56:47 2016

Migrate WTF::Vector::append() to ::push_back() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/bindings/*. There
are too many references to change them all at once, so this CL is part 1
of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2554693003
Cr-Commit-Position: refs/heads/master@{#437074}

[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/Iterable.h
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseTest.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/ToV8Test.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/TraceWrapperMemberTest.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/V8PersistentValueVector.h
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp
[modify] https://crrev.com/fdbfb17f86fe5080e59821de6b352b74044a044a/third_party/WebKit/Source/wtf/Vector.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b3f02e103d299860a03d92e415b8fb697840c70

commit 3b3f02e103d299860a03d92e415b8fb697840c70
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Dec 09 16:27:36 2016

Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2562773002
Cr-Commit-Position: refs/heads/master@{#437556}

[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/AnimationTimeline.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSOffsetRotationInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/EffectInput.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/EffectInputTest.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/EffectStack.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/EffectStack.h
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/EffectStackTest.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/ElementAnimation.h
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/ImageListPropertyFunctions.h
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/InterpolationEffect.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/InterpolationEffect.h
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/KeyframeEffectTest.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/SVGNumberListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/SVGPointListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/animatable/AnimatableRepeatable.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/css/CSSAnimationData.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/css/CSSTimingData.cpp
[modify] https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70/third_party/WebKit/Source/core/animation/css/CSSTransitionData.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8066fbcdc10ddb7020340708a84df4aeb0099c1e

commit 8066fbcdc10ddb7020340708a84df4aeb0099c1e
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Dec 14 02:52:20 2016

Migrate WTF::Vector::append() to ::push_back() [part 3 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/css/.
There are too many references to change them all at once, so this CL is
part 3 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2566403003
Cr-Commit-Position: refs/heads/master@{#438405}

[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSBasicShapeValues.h
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSGradientValue.h
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSValueList.h
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/CSSVariableData.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/MediaList.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/MediaQuery.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/PageRuleCollector.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/RuleFeature.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/RuleSet.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/StylePropertySet.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/CSSTransformValue.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValue.h
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/CSSUnparsedValueTest.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/CSSVariableReferenceValueTest.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSParserObserverWrapper.h
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/MediaQueryParser.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/MatchResult.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/MatchResultTest.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/8066fbcdc10ddb7020340708a84df4aeb0099c1e/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c9156393f43d8bd0c7047177d23e5f353cddb2b

commit 4c9156393f43d8bd0c7047177d23e5f353cddb2b
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Dec 14 19:40:28 2016

Migrate WTF::Vector::append() to ::push_back() [part 5 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/editing/.
There are too many references to change them all at once, so this CL is
part 5 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2571953004
Cr-Commit-Position: refs/heads/master@{#438597}

[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/GranularityStrategyTest.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/MergeIdenticalElementsCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/iterators/FullyClippedStateStack.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupAccumulator.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
[modify] https://crrev.com/4c9156393f43d8bd0c7047177d23e5f353cddb2b/third_party/WebKit/Source/core/editing/state_machines/StateMachineTestUtil.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e05477ef3d14d47f59a794a9efa00e0f476bdad

commit 3e05477ef3d14d47f59a794a9efa00e0f476bdad
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Dec 14 21:16:55 2016

Migrate WTF::Vector::append() to ::push_back() [part 4 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/dom/.
There are too many references to change them all at once, so this CL is
part 4 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2574773002
Cr-Commit-Position: refs/heads/master@{#438623}

[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/AttributeCollection.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/CSSSelectorWatchTest.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ChildFrameDisconnector.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ClientRectList.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ClientRectList.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ContainerNode.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ContainerNode.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/DOMStringList.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/DOMTokenList.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/DatasetDOMStringMap.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ElementRareData.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/NodeRareData.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ScriptedAnimationControllerTest.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/StyleSheetCollection.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/TouchList.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/URLSearchParams.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/CustomElementReactionQueue.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/CustomElementReactionTestHelpers.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElementCallbackQueue.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskDispatcher.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElementProcessingStack.h
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/custom/V0CustomElementSyncMicrotaskQueue.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/shadow/DistributedNodes.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
[modify] https://crrev.com/3e05477ef3d14d47f59a794a9efa00e0f476bdad/third_party/WebKit/Source/core/dom/shadow/SlotAssignment.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0d1b3eef68419a0116b19438a117e49e9600de

commit 5b0d1b3eef68419a0116b19438a117e49e9600de
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Dec 19 15:51:56 2016

Migrate WTF::Vector::append() to ::push_back() [part 6 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/events/,
fetch/, fileapi/, and frame/. There are too many references to change
them all at once, so this CL is part 6 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2585283002
Cr-Commit-Position: refs/heads/master@{#439480}

[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/EventListenerMap.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/EventSender.h
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/GenericEventQueue.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/InputEvent.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/PointerEvent.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/PointerEventFactoryTest.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/ScopedEventQueue.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/TreeScopeEventContext.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/events/TreeScopeEventContext.h
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fetch/CrossOriginAccessControl.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fetch/MemoryCache.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fileapi/FileList.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fileapi/FileList.h
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/HostsUsingFeatures.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/Navigator.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/RemoteFrame.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/SmartClip.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/CSPDirectiveListTest.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/MediaListDirectiveTest.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
[modify] https://crrev.com/5b0d1b3eef68419a0116b19438a117e49e9600de/third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26fe71ae1a0258090c65ced3e844fd3161a5833c

commit 26fe71ae1a0258090c65ced3e844fd3161a5833c
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Dec 20 04:20:37 2016

Migrate WTF::Vector::append() to ::push_back() [part 7 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/html/.
There are too many references to change them all at once, so this CL is
part 7 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2583233002
Cr-Commit-Position: refs/heads/master@{#439704}

[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/CollectionItemsCache.h
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/FormData.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLCollection.h
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLDimension.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLIFrameElementPermissions.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLMetaElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/forms/FileInputType.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/forms/FileInputTypeTest.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/forms/FormController.h
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/imports/HTMLImport.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/CompactHTMLToken.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/TextDocumentParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/parser/TokenizedChunkQueue.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/track/AutomaticTrackSelection.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/track/CueTimeline.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/track/TrackListBase.h
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp
[modify] https://crrev.com/26fe71ae1a0258090c65ced3e844fd3161a5833c/third_party/WebKit/Source/core/html/track/vtt/VTTRegionList.cpp

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb828314da9513edbeee7782f0c1d4c5c0a9bf3

commit abb828314da9513edbeee7782f0c1d4c5c0a9bf3
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Jan 06 02:22:22 2017

Migrate WTF::Vector::append() to ::push_back() [part 11 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/page/.
There are too many references to change them all at once, so this CL is
part 11 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2614033002
Cr-Commit-Position: refs/heads/master@{#441829}

[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/DragData.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/FrameTree.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/PageAnimator.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/PrintContext.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/PrintContextTest.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/TouchDisambiguation.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/WindowFeatures.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/abb828314da9513edbeee7782f0c1d4c5c0a9bf3/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c41acedb493c6d405f2f9bb665e6d366e33a45dc

commit c41acedb493c6d405f2f9bb665e6d366e33a45dc
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Jan 06 02:25:06 2017

Migrate WTF::Vector::append() to ::push_back() [part 15 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/web/.

There are too many references to change them all at once, so this CL is
part 15 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2612903007
Cr-Commit-Position: refs/heads/master@{#441830}

[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/CompositionUnderlineVectorBuilder.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebDOMActivityLogger.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebDocument.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebFileChooserCompletionImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebFormElement.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebFrameSerializer.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebHistoryItem.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebIDBKey.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebSearchableFormData.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebTextCheckingCompletionImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebTextCheckingResult.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/MHTMLTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/ViewportTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/c41acedb493c6d405f2f9bb665e6d366e33a45dc/third_party/WebKit/Source/web/tests/sim/SimCanvas.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63351a797c6e1d4956efa89d082da3a7eb0b17b2

commit 63351a797c6e1d4956efa89d082da3a7eb0b17b2
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Jan 06 02:30:03 2017

Migrate WTF::Vector::append() to ::push_back() [part 10 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/loader/.
There are too many references to change them all at once, so this CL is
part 10 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2614833005
Cr-Commit-Position: refs/heads/master@{#441833}

[modify] https://crrev.com/63351a797c6e1d4956efa89d082da3a7eb0b17b2/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/63351a797c6e1d4956efa89d082da3a7eb0b17b2/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/63351a797c6e1d4956efa89d082da3a7eb0b17b2/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
[modify] https://crrev.com/63351a797c6e1d4956efa89d082da3a7eb0b17b2/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParserTest.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/895c297c1ac92ad405a09263802ffecb2cc816a3

commit 895c297c1ac92ad405a09263802ffecb2cc816a3
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Jan 06 02:31:11 2017

Migrate WTF::Vector::append() to ::push_back() [part 8 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/inspector/.
There are too many references to change them all at once, so this CL is
part 8 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2610383002
Cr-Commit-Position: refs/heads/master@{#441834}

[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorHistory.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/895c297c1ac92ad405a09263802ffecb2cc816a3/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3d051c336e3b9c5a83d3187290b8eadeb7b438

commit 8b3d051c336e3b9c5a83d3187290b8eadeb7b438
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Jan 09 16:22:16 2017

Migrate WTF::Vector::append() to ::push_back() [part 16 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/build/scripts/templates/.

There are too many references to change them all at once, so this CL is
part 16 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2610893005
Cr-Commit-Position: refs/heads/master@{#442260}

[modify] https://crrev.com/8b3d051c336e3b9c5a83d3187290b8eadeb7b438/third_party/WebKit/Source/build/scripts/templates/CSSOMKeywords.cpp.tmpl
[modify] https://crrev.com/8b3d051c336e3b9c5a83d3187290b8eadeb7b438/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl
[modify] https://crrev.com/8b3d051c336e3b9c5a83d3187290b8eadeb7b438/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/072eb5da1124e276529ba464b2765f834bff3388

commit 072eb5da1124e276529ba464b2765f834bff3388
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Jan 09 16:34:09 2017

Migrate WTF::Vector::append() to ::push_back() [part 9 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/layout/.
There are too many references to change them all at once, so this CL is
part 9 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2610253004
Cr-Commit-Position: refs/heads/master@{#442264}

[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/BidiRunForLine.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ColumnBalancer.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/FlexibleBoxAlgorithm.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutInline.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.h
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/TableLayoutAlgorithmFixed.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/InlineIterator.h
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/RootInlineBox.h
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/line/TrailingObjects.h
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/ng/ng_units.cc
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGContainer.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGImage.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
[modify] https://crrev.com/072eb5da1124e276529ba464b2765f834bff3388/third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1

commit e23ac2114da2a67a3e62e29eebd8f9192c83e8d1
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Jan 09 16:48:53 2017

Migrate WTF::Vector::append() to ::push_back() [part 12 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/svg, timing,
workers, and xml.

There are too many references to change them all at once, so this CL is
part 12 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617783002
Cr-Commit-Position: refs/heads/master@{#442267}

[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/input/BoundaryEventDispatcher.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/observer/ResizeObserver.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/BoxClipper.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/GridPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/LayerClipRecorder.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/ObjectPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/style/BasicShapes.h
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/style/FilterOperationsTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/style/QuotesData.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/style/ShadowList.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGAngle.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGComponentTransferFunctionElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFETileElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGGradientElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGStringList.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGTextPathElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGTransformList.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/SVGUnitTypes.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/UnsafeSVGAttributeSanitizationTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/testing/DeathAwareScriptWrappable.h
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/testing/LayerRectList.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceObserverEntryList.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceObserverTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/workers/WorkerThreadStartupData.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/DocumentXMLTreeViewer.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XPathExpressionNode.h
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XPathFunctionsTest.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XPathNodeSet.h
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XPathPath.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XPathStep.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp
[modify] https://crrev.com/e23ac2114da2a67a3e62e29eebd8f9192c83e8d1/third_party/WebKit/Source/core/xml/parser/XMLErrors.cpp

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8702f9b3c88ac69fa7190e87bdb2d4fcdba594db

commit 8702f9b3c88ac69fa7190e87bdb2d4fcdba594db
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Jan 13 01:51:11 2017

Migrate WTF::Vector::append() to ::push_back() in XPathGrammar

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL changes the template file that is used to generate
XPathGrammar.cpp.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2627023004
Cr-Commit-Position: refs/heads/master@{#443452}

[modify] https://crrev.com/8702f9b3c88ac69fa7190e87bdb2d4fcdba594db/third_party/WebKit/Source/core/xml/XPathGrammar.y

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/237a04c31ab855d78f777e907341dc520b2d2c71

commit 237a04c31ab855d78f777e907341dc520b2d2c71
Author: pilgrim <pilgrim@chromium.org>
Date: Sat Jan 14 01:27:50 2017

Migrate WTF::Vector::append() to ::push_back() in binding templates

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/binding/templates/
which affects several generated V8 bindings (V8Document, V8Location,
and V8Window).

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2628973007
Cr-Commit-Position: refs/heads/master@{#443759}

[modify] https://crrev.com/237a04c31ab855d78f777e907341dc520b2d2c71/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/237a04c31ab855d78f777e907341dc520b2d2c71/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/237a04c31ab855d78f777e907341dc520b2d2c71/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/237a04c31ab855d78f777e907341dc520b2d2c71/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54aad911b25fd13622a400c73fc8b3bd0026ebda

commit 54aad911b25fd13622a400c73fc8b3bd0026ebda
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Jan 25 19:08:24 2017

Migrate WTF::Vector::append() to ::push_back() [part 17 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes a number of scattered references to append() that were
missed in previous CLs or added to the code since then.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2653203003
Cr-Commit-Position: refs/heads/master@{#446074}

[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
[modify] https://crrev.com/54aad911b25fd13622a400c73fc8b3bd0026ebda/third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a980b812f2f213270551f986fc7c4fdf0cc2d3a8

commit a980b812f2f213270551f986fc7c4fdf0cc2d3a8
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Jan 26 02:59:38 2017

Migrate WTF::HashSet::add() to ::insert() [part 1 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add(). However, there are several subclasses of HashSet which inherit
all the methods, and this CL does not attempt to change references to
those subclasses. (A future CL will do exactly that.)

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2657443005
Cr-Commit-Position: refs/heads/master@{#446215}

[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/AnimationTimeline.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/EffectStackTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/SampledEffect.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/cssom/FilteredComputedStylePropertyMap.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/css/resolver/StyleRuleUsageTracker.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/DocumentParser.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/DocumentStyleSheetCollector.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/MutationObserverRegistration.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/NodeRareData.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/Range.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/ResizeObserverController.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/SecurityContext.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/VisitedLinkState.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/custom/CustomElementDescriptorTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/events/EventDispatcher.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/FrameConsole.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/SubresourceIntegrity.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/csp/MediaListDirective.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLCollection.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLDocument.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/SubtreeLayoutScope.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/layout/svg/SVGResourcesCycleSolver.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/page/TouchDisambiguation.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGLinearGradientElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGPatternElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGRadialGradientElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/xml/XPathFunctions.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/xml/XPathParser.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/xml/XPathPath.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/core/xml/XPathPredicate.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/accessibility/AXTable.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/time_zone_monitor/TimeZoneMonitorClient.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webgl/WebGLContextGroup.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/LifecycleNotifier.h
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp
[modify] https://crrev.com/a980b812f2f213270551f986fc7c4fdf0cc2d3a8/third_party/WebKit/Source/platform/gr
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb3a30a6acb4e3e774f9c0d416bb90c270065364

commit cb3a30a6acb4e3e774f9c0d416bb90c270065364
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Jan 26 16:26:17 2017

Migrate WTF::Vector::append() to ::push_back() in WTF::HexNumber

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL uses template specialization on WTF::HexNumber::appendByteAsHex,
which needs to support classes (like WTF::Vector) that are being
migrated to push_back() while other classes (like WTF::StringBuilder)
are still using an append() method.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2622363005
Cr-Commit-Position: refs/heads/master@{#446345}

[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/core/css/CSSMarkup.cpp
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/platform/graphics/Color.cpp
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/wtf/HexNumber.h
[modify] https://crrev.com/cb3a30a6acb4e3e774f9c0d416bb90c270065364/third_party/WebKit/Source/wtf/text/WTFString.cpp

Project Member

Comment 25 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8faf8ffd77d4629e3471372d3db338349fa931

commit fa8faf8ffd77d4629e3471372d3db338349fa931
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Jan 26 19:59:03 2017

Migrate WTF::HashSet::add() to ::insert() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL fixes many (but not all) references to use insert() instead of
add() in subclasses of HashSet.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2654033007
Cr-Commit-Position: refs/heads/master@{#446412}

[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp
[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/wtf/DequeTest.cpp
[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/wtf/HashSetTest.cpp
[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/wtf/VectorTest.cpp
[modify] https://crrev.com/fa8faf8ffd77d4629e3471372d3db338349fa931/third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e15bee70f49af0442300b3b4d59a7a65ed0555e

commit 6e15bee70f49af0442300b3b4d59a7a65ed0555e
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Feb 03 03:48:39 2017

Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to one type of remove()
method (that takes a KeyPeekInType).

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2673543003
Cr-Commit-Position: refs/heads/master@{#447913}

[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/css/CSSStyleRule.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/ResizeObserver.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/WeakIdentifierMap.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/ImageQualityController.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/page/scrolling/ScrollCustomizationCallbacks.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/canvas2d/HitRegion.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/mediastream/MediaStreamRegistry.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/Length.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/Supplementable.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/blob/BlobRegistry.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/json/JSONValues.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/network/HTTPHeaderMap.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/wtf/HashMap.h
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/wtf/HashMapTest.cpp
[modify] https://crrev.com/6e15bee70f49af0442300b3b4d59a7a65ed0555e/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb710b631287aea4df1536d05046e750184a7bda

commit fb710b631287aea4df1536d05046e750184a7bda
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Feb 03 19:18:19 2017

Migrate WTF::HashMap::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

This CL migrates most, but not all references to add(). A future CL
will complete the migration and remove the add() method altogether.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2671933002
Cr-Commit-Position: refs/heads/master@{#448037}

[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/animation/EffectStack.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/CSSValuePool.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/RuleFeature.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/RuleSet.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/ChildListMutationScope.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/ElementDataCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/NodeListsNodeData.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/NthIndexCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/UserActionElementSet.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/V0CustomElementObserver.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/V0CustomElementScheduler.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/events/EventPath.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/frame/HostsUsingFeatures.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/HTMLCollection.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/imports/HTMLImport.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutAttributesBuilder.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/page/NetworkStateNotifier.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/page/TouchDisambiguation.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/testing/DeathAwareScriptWrappable.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/filesystem/DraggedIsolatedFileSystemImpl.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/mediasource/TrackDefaultList.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/LayoutLocale.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/blob/BlobRegistry.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/fonts/shaping/ShapeCache.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/CompositorMutableStateProvider.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/OffscreenCanvasPlaceholder.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/graphics/paint/RasterInvalidationTracking.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/heap/HeapCompact.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/loader/fetch/MemoryCache.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/network/HTTPHeaderMap.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/text/BidiResolver.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/web/tests/sim/SimNetwork.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/wtf/HashCountedSet.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/wtf/HashMap.h
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/wtf/HashMapTest.cpp
[modify] https://crrev.com/fb710b631287aea4df1536d05046e750184a7bda/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9245a032ae8afde088def22c747bdb78d423a0ff

commit 9245a032ae8afde088def22c747bdb78d423a0ff
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Feb 10 20:16:14 2017

Migrate WTF::HashMap::add() to ::insert() [final]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL completes the migration process from add() to insert() and
removes the add() methods from HashMap.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2693433002
Cr-Commit-Position: refs/heads/master@{#449715}

[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/mojo/public/cpp/bindings/map_traits_wtf_hash_map.h
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/wtf/HashMap.h
[modify] https://crrev.com/9245a032ae8afde088def22c747bdb78d423a0ff/third_party/WebKit/Source/wtf/text/StringImpl.cpp

Project Member

Comment 29 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9

commit 1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Feb 13 17:05:14 2017

Migrate WTF::HashSet::add() to ::insert() [continued]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL continues the migration process from add() to insert() and
removes one of the add() methods from HashSet.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2688893002
Cr-Commit-Position: refs/heads/master@{#449981}

[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.cpp
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/wtf/HashSet.h
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/1dc76b0c12e43cce0f8ca56e38c2f18eed2461a9/third_party/WebKit/Source/wtf/ListHashSet.h

Project Member

Comment 30 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9caf6364ab67c04029f037ffecb96169b681a469

commit 9caf6364ab67c04029f037ffecb96169b681a469
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Feb 16 23:55:39 2017

Migrate WTF::HashSet::remove() to ::erase() [part 1]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2696183002
Cr-Commit-Position: refs/heads/master@{#451141}

[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/animation/AnimationTimeline.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/DocumentParser.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/NodeRareData.h
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/QualifiedName.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/events/EventDispatcher.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/frame/PlatformEventDispatcher.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/layout/svg/SVGResourcesCycleSolver.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/xml/XPathNodeSet.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/core/xml/XPathParser.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/shapedetection/TextDetector.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/AudioListener.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/AudioParam.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/LifecycleNotifier.h
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/MemoryCoordinator.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/web/AnimationWorkletProxyClientImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/web/CompositorWorkerProxyClientImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/web/OpenedFrameTracker.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/wtf/DequeTest.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/wtf/HashSet.h
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/wtf/HashSetTest.cpp
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/wtf/HashTable.h
[modify] https://crrev.com/9caf6364ab67c04029f037ffecb96169b681a469/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 31 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d13bd4b7858208f2fb37cfea437e06b8a95902bc

commit d13bd4b7858208f2fb37cfea437e06b8a95902bc
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Feb 21 19:25:27 2017

Migrate WTF::HashSet::remove() to ::erase() [part 2]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2703833002
Cr-Commit-Position: refs/heads/master@{#451817}

[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/layout/DepthOrderedLayoutObjectList.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/modules/webusb/USBDevice.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/wtf/HashSet.h
[modify] https://crrev.com/d13bd4b7858208f2fb37cfea437e06b8a95902bc/third_party/WebKit/Source/wtf/text/AtomicStringTable.cpp

Project Member

Comment 32 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c

commit 2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Feb 23 16:00:22 2017

Migrate WTF::HashMap::get() to ::at()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709033003
Cr-Commit-Position: refs/heads/master@{#452504}

[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/bindings/core/v8/DOMWrapperMap.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/bindings/core/v8/V8GlobalValueMap.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/build/scripts/templates/ElementTypeHelpers.cpp.tmpl
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/animation/EffectStackTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/animation/StringKeyframe.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/CSSStyleRule.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/PropertyRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/RuleSet.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/NodeListsNodeData.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/NthIndexCache.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/ProcessingInstruction.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/WeakIdentifierMap.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/editing/serializers/MarkupFormatter.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/frame/OriginsUsingFeaturesTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/HTMLCollection.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/imports/HTMLImport.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorResourceContainer.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/Grid.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutScrollbar.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/page/TouchAdjustment.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/style/StyleInheritedVariables.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/style/StyleNonInheritedVariables.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/style/StyleNonInheritedVariables.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/svg/SVGElement.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/svg/SVGLength.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/timing/PerformanceUserTiming.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/xml/XPathVariableReference.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/canvas2d/HitRegion.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/mediasource/MediaSourceRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/mediastream/MediaStreamRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/modules/webusb/USB.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/Length.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/Supplementable.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/blob/BlobRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump.cc
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/loader/fetch/MemoryCache.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/mhtml/MHTMLArchive.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/network/HTTPHeaderMap.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/network/ParsedContentType.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/web/WebEntities.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/wtf/HashCountedSet.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/wtf/HashMap.h
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/wtf/HashMapTest.cpp
[modify] https://crrev.com/2fb6ae93c1a3a90f6d3576d50ad8d22219a2757c/third_party/WebKit/Source/wtf/text/TextEncodingRegistry.cpp

Project Member

Comment 33 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8

commit 0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Mar 02 17:00:11 2017

Migrate WTF::LinkedHashSet/ListHashSet::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2724363002
Cr-Commit-Position: refs/heads/master@{#454286}

[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/dom/DocumentOrderedList.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/dom/ResizeObserver.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/HitTestResult.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/modules/canvas2d/HitRegion.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/platform/heap/ThreadState.h
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/wtf/ListHashSet.h
[modify] https://crrev.com/0d6974fcc661b4ff8ae9e4b04eb26bb5758512a8/third_party/WebKit/Source/wtf/ListHashSetTest.cpp

Project Member

Comment 34 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1e9bdb6d21349e58a1c1bc6444d776967768011

commit c1e9bdb6d21349e58a1c1bc6444d776967768011
Author: pilgrim <pilgrim@chromium.org>
Date: Fri Mar 03 18:36:25 2017

Migrate WTF::LinkedHashSet/ListHashSet::first() to ::front()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2722413005
Cr-Commit-Position: refs/heads/master@{#454631}

[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/wtf/ListHashSet.h
[modify] https://crrev.com/c1e9bdb6d21349e58a1c1bc6444d776967768011/third_party/WebKit/Source/wtf/ListHashSetTest.cpp

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7279ec4f24f817ebf896786e0497cea494658243

commit 7279ec4f24f817ebf896786e0497cea494658243
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Mar 07 21:46:04 2017

Migrate WTF::LinkedHashSet/ListHashSet::last() to ::back()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2725343002
Cr-Commit-Position: refs/heads/master@{#455227}

[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp
[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/wtf/ListHashSet.h
[modify] https://crrev.com/7279ec4f24f817ebf896786e0497cea494658243/third_party/WebKit/Source/wtf/ListHashSetTest.cpp

Project Member

Comment 36 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d80c4b7df762231c28fd4349a35cd4e4408d635f

commit d80c4b7df762231c28fd4349a35cd4e4408d635f
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Mar 09 18:10:07 2017

Migrate WTF::LinkedHashSet/ListHashSet::removeLast() to ::pop_back()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2743743002
Cr-Commit-Position: refs/heads/master@{#455792}

[modify] https://crrev.com/d80c4b7df762231c28fd4349a35cd4e4408d635f/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/d80c4b7df762231c28fd4349a35cd4e4408d635f/third_party/WebKit/Source/wtf/ListHashSet.h
[modify] https://crrev.com/d80c4b7df762231c28fd4349a35cd4e4408d635f/third_party/WebKit/Source/wtf/ListHashSetTest.cpp

Project Member

Comment 37 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f34eac37bacb0cdcab1013543dc6267f762eddd0

commit f34eac37bacb0cdcab1013543dc6267f762eddd0
Author: pilgrim <pilgrim@chromium.org>
Date: Thu Mar 09 20:10:22 2017

Migrate WTF::LinkedHashSet/ListHashSet/HashTable::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2725063003
Cr-Commit-Position: refs/heads/master@{#455845}

[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/dom/DocumentOrderedList.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/dom/ResizeObserver.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/events/DOMWindowEventQueue.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/modules/canvas2d/HitRegion.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/platform/fonts/FontDataCache.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/wtf/LinkedHashSet.h
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/wtf/ListHashSet.h
[modify] https://crrev.com/f34eac37bacb0cdcab1013543dc6267f762eddd0/third_party/WebKit/Source/wtf/ListHashSetTest.cpp

Project Member

Comment 39 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5

commit 2c5d87086fe766b96f9e35cbd94be825b7a8a4f5
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Mar 13 16:31:34 2017

Migrate WTF::Deque::append() to ::push_back()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2743023002
Cr-Commit-Position: refs/heads/master@{#456397}

[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/frame/FrameSerializer.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/inspector/DOMPatchSupport.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/inspector/InspectorTaskRunner.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.h
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/platform/text/SegmentedString.cpp
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/2c5d87086fe766b96f9e35cbd94be825b7a8a4f5/third_party/WebKit/Source/wtf/DequeTest.cpp

Project Member

Comment 40 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c048822625c48c44e4e4336abc50c033ad8a251

commit 5c048822625c48c44e4e4336abc50c033ad8a251
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Mar 14 04:42:46 2017

Migrate WTF::Deque::removeFirst() to ::pop_front()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2749753002
Cr-Commit-Position: refs/heads/master@{#456623}

[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/5c048822625c48c44e4e4336abc50c033ad8a251/third_party/WebKit/Source/wtf/DequeTest.cpp

Project Member

Comment 41 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5469af36b09c670cc19ddd589b09bc14008210

commit 2c5469af36b09c670cc19ddd589b09bc14008210
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Mar 14 19:57:41 2017

Migrate WTF::Deque::first() to ::front()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2752593003
Cr-Commit-Position: refs/heads/master@{#456798}

[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/core/css/CSSFontFace.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/core/css/CSSFontFace.h
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/core/input/PointerEventManager.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/2c5469af36b09c670cc19ddd589b09bc14008210/third_party/WebKit/Source/wtf/DequeTest.cpp

Project Member

Comment 43 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1dd04d3aa422d619a76153946c2cf0061ed4e43

commit e1dd04d3aa422d619a76153946c2cf0061ed4e43
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Mar 15 16:05:56 2017

Migrate WTF::Deque::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2747373004
Cr-Commit-Position: refs/heads/master@{#457097}

[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/core/dom/ScriptRunner.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckRequester.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/e1dd04d3aa422d619a76153946c2cf0061ed4e43/third_party/WebKit/Source/wtf/DequeTest.cpp

Project Member

Comment 44 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e76855dc3592add7faf7bff91b730385fc83cb16

commit e76855dc3592add7faf7bff91b730385fc83cb16
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Mar 15 18:09:36 2017

Migrate WTF::Deque::prepend() to ::push_front()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2746763009
Cr-Commit-Position: refs/heads/master@{#457140}

[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/platform/heap/HeapCompactTest.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/platform/text/SegmentedString.cpp
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/wtf/Deque.h
[modify] https://crrev.com/e76855dc3592add7faf7bff91b730385fc83cb16/third_party/WebKit/Source/wtf/DequeTest.cpp

Project Member

Comment 45 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9

commit aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Mar 21 17:04:37 2017

Migrate WTF::HashMap::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2759703002
Cr-Commit-Position: refs/heads/master@{#458444}

[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/mojo/public/cpp/bindings/tests/wtf_map_unittest.cc
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/css/FontFaceCache.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/DocumentOrderedMap.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/IdTargetObserverRegistry.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/ResizeObserver.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/SelectorQuery.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/UserActionElementSet.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/dom/custom/V0CustomElementUpgradeCandidateMap.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/loader/private/CrossOriginPreflightResultCache.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/svg/SVGTreeScopeResources.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/modules/geolocation/GeolocationWatchers.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/modules/mediasource/MediaSourceRegistry.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/fonts/GenericFontFamilySettings.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/graphics/paint/RasterInvalidationTracking.h
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/loader/fetch/MemoryCache.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/wtf/HashCountedSet.h
[modify] https://crrev.com/aa4954b93c5c4a8e1924e31e675453f8ff9bbbd9/third_party/WebKit/Source/wtf/HashMap.h

Project Member

Comment 46 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26bacca94de2164ff021d1a091cb8cb41632636a

commit 26bacca94de2164ff021d1a091cb8cb41632636a
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Mar 21 19:31:26 2017

Migrate WTF::Vector::prepend() to ::push_front()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2766723002
Cr-Commit-Position: refs/heads/master@{#458510}

[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/core/editing/iterators/SearchBuffer.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/core/layout/ListMarkerText.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/wtf/HexNumber.h
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/wtf/Vector.h
[modify] https://crrev.com/26bacca94de2164ff021d1a091cb8cb41632636a/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 47 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e2545eea28039a76b9c056c84fddac3cbc9d7d8

commit 3e2545eea28039a76b9c056c84fddac3cbc9d7d8
Author: pilgrim <pilgrim@chromium.org>
Date: Tue Mar 28 20:51:34 2017

Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2776203002
Cr-Commit-Position: refs/heads/master@{#460215}

[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/clipboard/DataObject.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/CSSGradientValue.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/CSSGroupingRule.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/CSSStyleSheet.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/CSSValueList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/MediaList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/MediaQuery.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/StylePropertySet.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/StyleRule.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/StyleSheetContents.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/AttributeCollection.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/NodeRareData.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/URLSearchParams.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/dom/custom/V0CustomElementSyncMicrotaskQueue.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/editing/EditingStyle.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/events/EventListenerMap.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/events/GenericEventQueue.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/FormData.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/TimeRanges.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/track/CueTimeline.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/track/TextTrackList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/html/track/TrackListBase.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/loader/resource/MultipartImageResourceParser.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/svg/SVGStringList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/mediasource/SourceBufferList.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/PODIntervalTreeTest.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/json/JSONValues.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/network/NetworkStateNotifier.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/testing/ArenaTestHelpers.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/platform/wtf/Vector.h
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/3e2545eea28039a76b9c056c84fddac3cbc9d7d8/third_party/WebKit/Source/wtf/VectorTest.cpp

Project Member

Comment 48 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b06db87db43c1d78a7e23b87383fd61e011bb8b6

commit b06db87db43c1d78a7e23b87383fd61e011bb8b6
Author: pilgrim <pilgrim@chromium.org>
Date: Mon Apr 03 03:53:32 2017

Migrate WTF::RefVector::append() to ::push_back()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2788683005
Cr-Commit-Position: refs/heads/master@{#461366}

[modify] https://crrev.com/b06db87db43c1d78a7e23b87383fd61e011bb8b6/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
[modify] https://crrev.com/b06db87db43c1d78a7e23b87383fd61e011bb8b6/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/b06db87db43c1d78a7e23b87383fd61e011bb8b6/third_party/WebKit/Source/platform/wtf/RefVector.h

Project Member

Comment 49 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa

commit e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Apr 05 02:07:39 2017

Migrate WTF::HashCountedSet::add() to ::insert()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2796163002
Cr-Commit-Position: refs/heads/master@{#461936}

[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/html/HTMLDocument.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/e631c8f4709efa21fbe0926ae3cb3b2ff5a9acaa/third_party/WebKit/Source/platform/wtf/HashCountedSet.h

Project Member

Comment 50 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a097aa0c267a3ac5dc99af963461148fb64bb6a0

commit a097aa0c267a3ac5dc99af963461148fb64bb6a0
Author: pilgrim <pilgrim@chromium.org>
Date: Wed Apr 05 16:04:05 2017

Migrate WTF::HashCountedSet::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2799573003
Cr-Commit-Position: refs/heads/master@{#462091}

[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/html/HTMLDocument.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/core/svg/SVGElementProxy.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/modules/webdatabase/Database.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/a097aa0c267a3ac5dc99af963461148fb64bb6a0/third_party/WebKit/Source/platform/wtf/HashCountedSet.h

Components: Blink>Internals>WTF
Owner: ----
Status: Available (was: Started)
Anything left to do here?

Sign in to add a comment