New issue
Advanced search Search tips

Issue 662420 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression

Blocked on:
issue 663450



Sign in to add a comment

Name of public session pods are broken.

Project Member Reported by tnagel@chromium.org, Nov 4 2016

Issue description

Sasha, could that (cf. attachment) be fallout from your account id changes?
 
public_session.png
89.0 KB View Download
Any updates? We go beta in a few weeks. Is this still seen on ToT?
The last actual "change" I landed was long ago. I refactored some code, but there were no logical changes.

I'll look into it but I don't remember updating anything related to this recently.
Labels: Needs-Bisect
Cc: alemate@chromium.org
Owner: tnagel@chromium.org
I checked that if UpdatePublicAccountDisplayName() at https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc?rcl=0&l=1058 is successful, then public sessions will have correct display names.

Thiemo, are you sure that your policy has correct display name?
Can it be a problem with DeviceLocalAccountPolicyBroker ?

Comment 5 by tnagel@chromium.org, Nov 11 2016

Blockedon: 663450
I'm very sure this has worked in the past, and I'd be happy to bisect it but bisect-builds.py is broken, cf. issue 663450.

Comment 6 by tnagel@chromium.org, Nov 15 2016

Owner: ----
Status: Available (was: Assigned)
I'm not the right owner for this.
Drew, could you find someone to look at this?

I checked that if UpdatePublicAccountDisplayName() is successful, will PODs have correct names. But I don't have real enterprise domain for this, I just patched code to add public PODs. Could someone verify that policies are still applied correctly?
Cc: emaxx@chromium.org
Owner: isandrk@chromium.org
Maksim, did we change anything about the timing of when DeviceLocalAccountPolicyBroker was initialized? That would probably cause this (if GetBrokerForUser() returns null for some reason when policy is updated)

Ivan, I'm putting this on your plate for now, but you should stay heads-down on landing your UI changes for M56 before looking at this.

Comment 9 by emaxx@chromium.org, Nov 18 2016

> Maksim, did we change anything about the timing of when
> DeviceLocalAccountPolicyBroker was initialized? That would
> probably cause this (if GetBrokerForUser() returns null for
> some reason when policy is updated)

I think my change could only make some policy-depending stuff initialize _earlier_ for the device-local accounts, if any change.

Also, how can I reproduce this? On ToT build with an enterprise-enrolled profile, I see the normal "Public Playground" name on the Public Session pod. Is some special policy setup required for reproducing this?
Status: WontFix (was: Available)
Works for me on ToT (80ff2be8079778b471c4afdf0a3061f5f088376f).  Apparently it got fixed in the mean time.

Sign in to add a comment