=== Auto-CCing suspected CL author guidou@chromium.org ===
Hi guidou@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.
===== BISECT JOB RESULTS =====
Status: completed
===== SUSPECTED CL(s) =====
Subject : Remove MediaStreamTrack.getSources().
Author : guidou
Commit description:
Intent-to-remove thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/do3t86PtHCY
BUG= 649710 , 388194
Review-Url: https://codereview.chromium.org/2471803002
Cr-Commit-Position: refs/heads/master@{#429745}
Commit : 3ea42b21339ebf028e0ff6e368ca60d463386dd2
Date : Fri Nov 04 01:01:39 2016
===== TESTED REVISIONS =====
Revision Mean Std Dev N Good?
chromium@429714 113419025 1850265 5 good
chromium@429738 113842645 2072769 5 good
chromium@429744 114380380 4212428 5 good
chromium@429745 128451319 7268919 5 bad <--
chromium@429746 133805330 9255801 5 bad
chromium@429747 135154664 7414207 5 bad
chromium@429750 135422234 8745031 5 bad
chromium@429761 134187333 8503648 5 bad
Bisect job ran on: linux_perf_bisect
Bug ID: 662414
Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.long_running_idle_gmail_tbmv2
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg
Relative Change: 18.31%
Score: 99.0
Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6819
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8996912788398573984
Not what you expected? We'll investigate and get back to you!
https://chromeperf.appspot.com/bad_bisect?try_job_id=5819135970246656
| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
| X | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect. Thank you!
I guess the benchmark was using that function. Now takes a code path that was not recorded by telemetry and throws errors which prevents idle time GC from kicking in.
We probably need to re-record the benchmark.
I can prepare a revert, but I think you should fix the broken metric, which is the actual cause of the error.
This JavaScript function has been deprecated for months and was scheduled for deletion in M56.
I'm in the process of reverting everything now. It should be ready in a few hours.
However I will try to reland before the branch since we have to remove that function.
This regression has been included in a stable release and that stable channel is now deprecated. I'm closing this so that we won't have unresponsive performance regressions in the future.
Comment 1 by ulan@google.com
, Nov 4 2016