Issue metadata
Sign in to add a comment
|
Regression: The Native Mac Page Info and Permissions Bubble is no longer aligned below the Lock Icon |
||||||||||||||||||||||||
Issue descriptionVersion: Chrome 56.0.2909.0 canary (64-bit) OS: Mac OS 10.11.6 on a non-retina MacBook Air What steps will reproduce the problem? (1) go to https://www.google.com/ (2) click on the lock icon, so that Mac Page Info Bubble appears What is the expected output? The bubble is not aligned. What do you see instead? It should be aligned. Please use labels and text to provide additional information. I did a bisect. The regression range is https://chromium.googlesource.com/chromium/src/+log/192ccd60638f4cfa0b4b0ea89c896bb323c57871..75863c4176f633730b0388893f46ccafaad4cc88 Probably caused by https://chromium.googlesource.com/chromium/src/+/f8c2ce99bb1ee0b1c6edb56d4194ecd886c76b8c spqchan@: Can you please take a look? Thanks. Mehmet
,
Nov 9 2016
Issue 663664 has been merged into this issue.
,
Nov 9 2016
,
Nov 10 2016
,
Nov 13 2016
,
Nov 14 2016
,
Nov 14 2016
,
Nov 15 2016
,
Nov 18 2016
Can we get an update on the CL under review.
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1b792a63088465603c079e7dc1037acb2b67427 commit f1b792a63088465603c079e7dc1037acb2b67427 Author: spqchan <spqchan@chromium.org> Date: Fri Nov 18 20:16:11 2016 [Mac] Fix for omnibox lock icon - Align the permission bubble to be below the Lock Icon - Fix blurry lock icon BUG= 662411 , 662365 Review-Url: https://codereview.chromium.org/2503713002 Cr-Commit-Position: refs/heads/master@{#433283} [modify] https://crrev.com/f1b792a63088465603c079e7dc1037acb2b67427/chrome/browser/ui/cocoa/location_bar/image_decoration.mm [modify] https://crrev.com/f1b792a63088465603c079e7dc1037acb2b67427/chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm [modify] https://crrev.com/f1b792a63088465603c079e7dc1037acb2b67427/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
,
Nov 18 2016
,
Nov 18 2016
,
Nov 18 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 18 2016
,
Nov 19 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4f0c7b3e73f274c4606f201385539d328e1f5da commit d4f0c7b3e73f274c4606f201385539d328e1f5da Author: spqchan <spqchan@chromium.org> Date: Mon Nov 21 18:55:56 2016 [Mac] Fix for omnibox lock icon - Align the permission bubble to be below the Lock Icon - Fix blurry lock icon BUG= 662411 , 662365 Review-Url: https://codereview.chromium.org/2503713002 Cr-Commit-Position: refs/heads/master@{#433283} (cherry picked from commit f1b792a63088465603c079e7dc1037acb2b67427) Review URL: https://codereview.chromium.org/2521033002 . Cr-Commit-Position: refs/branch-heads/2924@{#32} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d4f0c7b3e73f274c4606f201385539d328e1f5da/chrome/browser/ui/cocoa/location_bar/image_decoration.mm [modify] https://crrev.com/d4f0c7b3e73f274c4606f201385539d328e1f5da/chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm [modify] https://crrev.com/d4f0c7b3e73f274c4606f201385539d328e1f5da/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
,
Nov 21 2016
,
Dec 13 2016
Already merged, removing TBD label.
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Nov 4 2016