New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662409 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

RequestFinishedInfo.getAnnotations() sometimes returns null

Project Member Reported by mge...@chromium.org, Nov 4 2016

Issue description

This was reported coming from the BidirectionalStream implementation. It should return an empty collection, not null.

 
Cc: huangsz@google.com

Comment 2 by huangsz@google.com, Nov 4 2016

FYI.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9d1b6c7804b11669012145c313e9adc58271684

commit e9d1b6c7804b11669012145c313e9adc58271684
Author: mgersh <mgersh@chromium.org>
Date: Fri Nov 04 21:07:40 2016

Fix null annotations, and move checks into RequestFinishedInfo

RequestFinishedInfo.getAnnotations() was returning null instead of an
empty collection when used with BidirectionalStream. It now returns an
empty collection instead, and the code to do this is moved out of the
builders into RequestFinishedInfo.

BUG= 662409 

Review-Url: https://codereview.chromium.org/2476983002
Cr-Commit-Position: refs/heads/master@{#430013}

[modify] https://crrev.com/e9d1b6c7804b11669012145c313e9adc58271684/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
[modify] https://crrev.com/e9d1b6c7804b11669012145c313e9adc58271684/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
[modify] https://crrev.com/e9d1b6c7804b11669012145c313e9adc58271684/components/cronet/android/java/src/org/chromium/net/impl/UrlRequestBuilderImpl.java
[modify] https://crrev.com/e9d1b6c7804b11669012145c313e9adc58271684/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment