New issue
Advanced search Search tips

Issue 662406 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 661510



Sign in to add a comment

Difference between default and ignition: can't externalize twice

Project Member Reported by machenb...@chromium.org, Nov 4 2016

Issue description

# Minimized program:
function f() { externalizeString("foo"); }
f();
gc();gc();gc();gc();
f();

# Compared default with ignition_staging

# Flags of default:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --gc-interval=169 --expose-externalize-string --random-seed 2080744775
# Flags of ignition_staging:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --gc-interval=169 --expose-externalize-string --random-seed 2080744775 --ignition-staging

Difference:
Different total output lines: 0 vs. 4

### Start of configuration default:

### End of configuration default

### Start of configuration ignition_staging:
out9_ignition_staging/fuzz-07767.js.minimized:1: externalizeString() can't externalize twice.
function f() { externalizeString("foo"); }
               ^


### End of configuration ignition_staging
 
Labels: Restrict-View-Google
I'm not sure what externalizeString does and why it can't be called on a string twice, but could this be due to Ignition's lack of code aging? In FCG the f() gets aged and gced, which GCs the string literal used by it, and allows us to re-externalize (with a new string) on the second call. In Ignition we never age the code and it tries to externalize the original string in the second call. 
Cc: machenb...@chromium.org
Status: WontFix (was: Untriaged)
Yeah this is code aging related - I can repo it on full-codegen by passing "--no-age-code", so a VM detail not something javascript correctness issue.

Michael, can you suppress tests cases like this one? I'm going to mark as wontfix, but please reopen if we need to find another way to supress it.
Owner: machenb...@chromium.org
Status: Assigned (was: WontFix)
Assigning to myself to think about suppression.
Labels: -Restrict-View-Google

Sign in to add a comment