New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662404 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

iOS: rename EarlGrey tests from foo_eg_tests_host to foo_eg_tests

Project Member Reported by sdefresne@chromium.org, Nov 4 2016

Issue description

The _host suffix is a wart and should be removed to have the name inline with foo_unittests and other tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/103ee1e345eb36725297bb35e758cbbd023cb8a8

commit 103ee1e345eb36725297bb35e758cbbd023cb8a8
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Nov 08 10:38:34 2016

Rename XCTests test main target and output.

Refactor ios_xctest_test template in order to have the main target
correspond to the host application and to have the dynamic module
be a secondary target.

With this change ios_xctest_test("foo") { ... } will now create an
application named foo.app (instead of foo_host.app) and the target
will be correctly named foo (instead of foo_host).

Keep the old target foo_host and the foo_host.app as compatibility
until the downstream bots have been fixed to use the new names.

Rename ios_web_shell_test_host to ios_web_shell_egtests.

BUG= 662404 

Review-Url: https://codereview.chromium.org/2473103006
Cr-Commit-Position: refs/heads/master@{#430570}

[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/build/config/ios/Host-Info.plist
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/build/config/ios/Module-Info.plist
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/build/config/ios/rules.gni
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/ios/BUILD.gn
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/ios/build/bots/chromium.fyi/EarlGreyiOS.json
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/ios/build/bots/scripts/test_runner.py
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/ios/build/tools/convert_gn_xcodeproj.py
[modify] https://crrev.com/103ee1e345eb36725297bb35e758cbbd023cb8a8/ios/web/shell/test/BUILD.gn
[delete] https://crrev.com/c65c410f81061e8b6b2340bd82547206939ea746/ios/web/shell/test/Host-Info.plist
[delete] https://crrev.com/c65c410f81061e8b6b2340bd82547206939ea746/ios/web/shell/test/Module-Info.plist

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/eb62643bc6953fbc7b181f0332887dfc3a6a0419

commit eb62643bc6953fbc7b181f0332887dfc3a6a0419
Author: sdefresne <sdefresne@google.com>
Date: Tue Nov 08 16:38:26 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/d6269b63a934a64e3e4ce54bb413f319266d325f

commit d6269b63a934a64e3e4ce54bb413f319266d325f
Author: sdefresne <sdefresne@google.com>
Date: Fri Nov 18 09:31:09 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09cceadb789bf9836f6f3bb6bd342df94e34b15c

commit 09cceadb789bf9836f6f3bb6bd342df94e34b15c
Author: sdefresne <sdefresne@chromium.org>
Date: Fri Nov 18 11:20:31 2016

Cleanup ios_xctest_test template.

No caller of this template (neither upstream nor downstream) set
the use_new_naming_convention parameter, so remove support for it
from the template as last cleanup step.

BUG= 662404 

Review-Url: https://codereview.chromium.org/2512553005
Cr-Commit-Position: refs/heads/master@{#433176}

[modify] https://crrev.com/09cceadb789bf9836f6f3bb6bd342df94e34b15c/build/config/ios/rules.gni

Status: Fixed (was: Assigned)

Sign in to add a comment