New issue
Advanced search Search tips

Issue 662400 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature
V2



Sign in to add a comment

Enable offline login flow for Chromad.

Project Member Reported by tnagel@chromium.org, Nov 4 2016

Issue description

.
 
Labels: Enterprise-Triaged

Comment 2 by tnagel@chromium.org, Nov 21 2016

Labels: V2

Comment 3 by tnagel@chromium.org, Jan 31 2017

Labels: -Type-Bug Type-Feature
Labels: -Pri-3 Pri-1
Owner: rsorokin@chromium.org
Status: Started (was: Available)
Labels: M-59
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c46c166645ad80352881e692745cd2c30aa24f

commit d8c46c166645ad80352881e692745cd2c30aa24f
Author: rsorokin <rsorokin@chromium.org>
Date: Tue Apr 11 08:43:19 2017

Add AuthPolicyLoginHelper

Allows cancel all pending calls and restart AuthPolicy service. Used
for enrollment and login UI to proper cancel the flows.

Also
Add RestartAuthPolicyService into UpstartClient.
Make UI flows properly cancel pending authpolicy operations.
Add delays in the FakeAuthPolicy clients in JoinAdDomain and
Authenticate user calls.
Move writing password piping into the AuthPolicyLoginHelper.

BUG= 677487 , 662400 , 676337 , 675597 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2794493002
Cr-Commit-Position: refs/heads/master@{#463578}

[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/BUILD.gn
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_auth_policy_client_unittest.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_upstart_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/fake_upstart_client.h
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/upstart_client.cc
[modify] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/dbus/upstart_client.h
[add] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/login/auth/authpolicy_login_helper.cc
[add] https://crrev.com/d8c46c166645ad80352881e692745cd2c30aa24f/chromeos/login/auth/authpolicy_login_helper.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f61625dbac455f9e5876fc3ccbbb4952f21647

commit 41f61625dbac455f9e5876fc3ccbbb4952f21647
Author: rsorokin <rsorokin@chromium.org>
Date: Mon Apr 24 17:03:36 2017

Chromad: Allow offline login.

When user types password on the pod screen it tries to unlock cryptohome
and authenticate against Active Directory server (get TGT) at the same
time. In case decrypting fail - it cleans authpolicyd state (by
restart).
The point of Active Directory authentication is to get TGT (if possible) with the password user typed. Failure here is OK - that could mean e.g. server is not reachable.
We don't want to have user wait for the Active Directory Authentication on the pod screen. In the follow-up CL we're gonna to create KeyedService inside the session which would get status about last authentication and handle possible failures (e.g. suggest to re-login in case server became reachable)

BUG= 662400 
TEST=manual

Review-Url: https://codereview.chromium.org/2835473002
Cr-Commit-Position: refs/heads/master@{#466664}

[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chrome/browser/chromeos/login/existing_user_controller.h
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/dbus/fake_auth_policy_client_unittest.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/login/auth/authpolicy_login_helper.cc
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/login/auth/authpolicy_login_helper.h
[modify] https://crrev.com/41f61625dbac455f9e5876fc3ccbbb4952f21647/chromeos/login/auth/cryptohome_authenticator.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01014b7ca4112940ca3080729beba9701321620e

commit 01014b7ca4112940ca3080729beba9701321620e
Author: rsorokin <rsorokin@chromium.org>
Date: Fri Apr 28 12:26:29 2017

Chromad: Add GetUserStatus call into AuthPolicyClient

Also s/ActiveDirectoryAccountData/ActiveDirectoryAccountInfo

BUG= 662400 
TBR=xiyuan@chromium.org

Review-Url: https://codereview.chromium.org/2841103002
Cr-Commit-Position: refs/heads/master@{#467967}

[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/BUILD.gn
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/dbus/fake_auth_policy_client_unittest.cc
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/login/auth/authpolicy_login_helper.cc
[modify] https://crrev.com/01014b7ca4112940ca3080729beba9701321620e/chromeos/login/auth/authpolicy_login_helper.h

Labels: -M-59 M-60 Merge-Request-60
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 2 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: There is .grd file changes and we are only 59 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee074e7389ec45b5b851dc9052576905465e1daa

commit ee074e7389ec45b5b851dc9052576905465e1daa
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Tue Jun 06 10:12:03 2017

Chromad: Create AuthPolicyCredentialsManager

AuthPolicyCredentialsManager KeyedService service is created for every
Active Directory user profile.
It calls GetUserStatus at the start of service, each hour and on every
network connection.
Tests are coming...

BUG= 662400 
TBR=rsorokin@chromium.org

(cherry picked from commit 7ccdfaf7c1639a6f1e12d206fea9a608b6c33f44)

Review-Url: https://codereview.chromium.org/2860443002
Cr-Original-Commit-Position: refs/heads/master@{#476248}
Change-Id: Ie03e381e53e1f75b0f2e866da5ee1b1bd85372ac
Reviewed-on: https://chromium-review.googlesource.com/525533
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#178}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/ee074e7389ec45b5b851dc9052576905465e1daa/chrome/app/generated_resources.grd
[modify] https://crrev.com/ee074e7389ec45b5b851dc9052576905465e1daa/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/ee074e7389ec45b5b851dc9052576905465e1daa/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[add] https://crrev.com/ee074e7389ec45b5b851dc9052576905465e1daa/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h
[modify] https://crrev.com/ee074e7389ec45b5b851dc9052576905465e1daa/chrome/browser/profiles/profile_impl.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/741dae3ecc228308f198162b33f4eb18c0fc7b18

commit 741dae3ecc228308f198162b33f4eb18c0fc7b18
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Wed Jun 21 11:07:06 2017

Chromad: Tests for AuthPolicyCredentialsManager

Bug:  662400 
Change-Id: I25bdd20e0bc3bdd60d5ba8d4279eedd676281a91
Reviewed-on: https://chromium-review.googlesource.com/528097
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481171}
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.h
[add] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager_unittest.cc
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/741dae3ecc228308f198162b33f4eb18c0fc7b18/chromeos/dbus/fake_auth_policy_client.h

Status: Fixed (was: Started)
Is there any additional setting needed for enabling offline flow.It's not working in M60/Paine.
Status: Started (was: Fixed)
No. Steps should be:
1. Enroll device into Active Directory
2. Login with Active Directory user and then logout
3. Turn off the network
4. Login from the pod screen should work

Comment 20 by dskaram@google.com, Jul 28 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in kip as per comment#19

M	ChromeOS	Chrome	ARC	Type	Channel
60	9592.85.0	60.0.3112.112	(multiple)	release	stable

Sign in to add a comment