Fullscreen video doesn't bode well with transformed iframes
Reported by
jmprieto...@gmail.com,
Nov 4 2016
|
||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Go to http://run.plnkr.co/plunks/W1nKXhdVZWGFnhq201po/ 2. Play the video and make it fullscreen 3. Tap to show the video controls and interact with them What is the expected behavior? What went wrong? You can't interact with the video controls when the video is playing fullscreen. Did this work before? N/A Chrome version: 54.0.2840.68 Channel: stable OS Version: 6.0.1 Flash Version: NOTE: on desktop the play button is outside of the visible area, use an Android device or emulator to reproduce. I reported this issue before (#603145) and it was closed presumably because two different people tried to reproduce it only on desktop. There has been a change since I first reported this as #603145. Previously, while playing fullscreen with the controls hidden, you could only tap on a part of the screen to make the controls shown, now the controls are shown regardless where you tap. On desktop (you can use the devtools console to launch the video) there's a variation of the issue: the transformation is being applied to the video and the controls even in fullscreen mode.
,
Nov 4 2016
please provide device details(phone/tablet).
,
Nov 7 2016
It happens on every single Android device I've tried, emulators included.
,
Nov 7 2016
I am able to repro on Nexus9. This particular video, none of the buttons are working in full screen mode
,
Nov 11 2016
The link is hard to open, could you move it into github.io?
,
Nov 14 2016
,
Nov 14 2016
,
Nov 14 2016
I think Dan fixed a bunch of these cases in the past? -RBS since this is already on stable.
,
Nov 14 2016
What's happening here is that the mouse events are being scaled by the <iframe>'s transform (1.5x), but the control rendering is not. We have some leeway to override the behavior since it is the <video> being fullscreened, not the <iframe>. => liberato@ who knows the controls code better.
,
Nov 16 2016
sorry for the delay. was ooo. foolip: what's the desired behavior for full screen video with "iframe: scale(2.0)"? Should it apply? if i understand the spec right, the controls rendering in full screen on android is correct -- looks like fullscreen is supposed to add "transform:none !important". i tried some other combinations: when playing embedded video on android (i.e., not full screen), if one changes the scale and translates the controls onto the screen, then the UI does change scale. touch events work fine. the same holds true on desktop embedded playback. on desktop, the transform is applied in full screen too; the controls get bigger. one can interact with the controls normally if one translates them on-screen. in other words, its' the same as embedded playback on both desktop and android. i have no idea about the root cause of the difference. we set full screen overlay mode on android, but not desktop, which i suspect has something to do with it.
,
Nov 17 2016
,
Nov 17 2016
Looks like iframe { transform: scale(1.5); } is the problem?
Per https://fullscreen.spec.whatwg.org/#user-agent-level-style-sheet-defaults this would be fixed by the "transform:none !important" rule, but our fullscreen.css is not in sync with the spec. I'm working on that, but in the meantime, adding transform:none to the iframe:-webkit-full-screen block would probably fix the problem.
,
Oct 20 2017
still broken @ToT as of M64. over to foolip, since i've no idea what to do with it. :)
,
Nov 15 2017
Marking this as available to make it clear that I'm not actually working on it. Also making it P3 as it's not clear if this is affecting real sites out there. OP, if you discovered this while trying to work with fullscreen, and if this was a Chrome-specific quirk you came across that slowed you down, please comment again. That'd be good reason to increase the priority of fixing this.
,
Nov 16 2017
This issue was reported to the company I work for by one of its customers. The company is one of the leaders in the e-learning business and the customer is one of the biggest publishers out there.
,
Nov 16 2017
In http://run.plnkr.co/plunks/W1nKXhdVZWGFnhq201po/ it's actually not possible to start the video because the play button is offscreen, but I did some fiddling in dev tools and confirmed that a simple fix in fullscreen.css fixes this. Just need to write a test...
,
Nov 16 2017
An attempted fix in https://chromium-review.googlesource.com/c/chromium/src/+/774297
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c239fdde5b7a0603982150abde49c7a9ed6267 commit 40c239fdde5b7a0603982150abde49c7a9ed6267 Author: Philip Jägenstedt <foolip@chromium.org> Date: Fri Nov 17 10:13:32 2017 Add transform:none for fullscreen iframe elements Bug: 662393 Change-Id: I9a451d5ebb8901d146a1cfaa8a2281882a8ea58e Reviewed-on: https://chromium-review.googlesource.com/774297 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517357} [add] https://crrev.com/40c239fdde5b7a0603982150abde49c7a9ed6267/third_party/WebKit/LayoutTests/external/wpt/fullscreen/rendering/ua-style-iframe-manual.html [modify] https://crrev.com/40c239fdde5b7a0603982150abde49c7a9ed6267/third_party/WebKit/Source/core/css/fullscreen.css
,
Nov 17 2017
#15, thanks for that extra info, that's enough reason to prioritize it, and I've made a fix. Please see if it works as expected in Chrome Canary in a few days.
,
Nov 20 2017
On latest M64:64.0.3273.0 we are able to interact with the controls when the video is playing in fullscreen. Thanks
,
Nov 21 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by rsgav...@chromium.org
, Nov 4 2016Labels: triage-te