New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662385 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit 21 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

cc_unittests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by mkwst@chromium.org, Nov 4 2016

Issue description

cc_unittests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1):

RendererPixelTest/2.PremultipliedTextureWithBackground
GLRendererPixelTest.TextureQuadBatching
RendererPixelTest/0.PremultipliedTextureWithBackground
GLRendererPixelTest.NonPremultipliedTextureWithBackground
IntersectingQuadGLPixelTest/0.Y16VideoQuads
VideoGLRendererPixelTest.TwoColorY16Rect
IntersectingQuadGLPixelTest/1.Y16VideoQuads

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54356 is the first failure.

Looks like the reland in https://codereview.chromium.org/2461423002 is the culprit.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecb97fdbc7b5f0d11835455699b32243de517b73

commit ecb97fdbc7b5f0d11835455699b32243de517b73
Author: mkwst <mkwst@chromium.org>
Date: Fri Nov 04 12:46:03 2016

Revert of Reland "Fix HTML5 video blurry" (patchset #6 id:120001 of https://codereview.chromium.org/2461423002/ )

Reason for revert:
cc_unittests on Windows-7-SP1 failing on chromium.win/Win7 Tests (dbg)(1):

RendererPixelTest/2.PremultipliedTextureWithBackground
GLRendererPixelTest.TextureQuadBatching
RendererPixelTest/0.PremultipliedTextureWithBackground
GLRendererPixelTest.NonPremultipliedTextureWithBackground
IntersectingQuadGLPixelTest/0.Y16VideoQuads
VideoGLRendererPixelTest.TwoColorY16Rect
IntersectingQuadGLPixelTest/1.Y16VideoQuads

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54356 is the first fail

Looks like this reland is the culprit.

BUG=662385

Original issue's description:
> Reland "Fix HTML5 video blurry"
>
> Original CL: https://codereview.chromium.org/2418173002/
>
> Revert CL: https://codereview.chromium.org/2463103002/
>
> Changes: Skip failed gpu pixel tests until baseline is created.
>
> TBR=dalecurtis@chromium.org,ccameron@chromium.org,dpranke@chromium.org,enne@chromium.org,junov@chromium.org
> BUG= 615325 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
>
> Committed: https://crrev.com/4bfcc05d589ea7c232c4e207380135c1cf28e3d7
> Cr-Commit-Position: refs/heads/master@{#429849}

TBR=dongseong.hwang@chromium.org,enne@chromium.org,kbr@chromium.org,aleksandar.stojiljkovic@intel.com,dongseong.hwang@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 615325 

Review-Url: https://codereview.chromium.org/2474073004
Cr-Commit-Position: refs/heads/master@{#429866}

[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/output/gl_renderer.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/output/gl_renderer.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/output/gl_renderer_draw_cache.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/output/shader.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/output/shader.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/resources/resource_provider.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/resources/resource_provider.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/resources/video_resource_updater.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/data/yuv_stripes.png
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/data/yuv_stripes_alpha.png
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/data/yuv_stripes_clipped.png
[delete] https://crrev.com/904e5472e3416db9ba2c096da1c0c3d51f013469/cc/test/data/yuv_stripes_clipped_rgba.png
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/data/yuv_stripes_offset.png
[delete] https://crrev.com/904e5472e3416db9ba2c096da1c0c3d51f013469/cc/test/data/yuv_stripes_rgba.png
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/test_in_process_context_provider.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/cc/test/test_in_process_context_provider.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/components/test_runner/test_plugin.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/media/renderers/skcanvas_video_renderer.cc
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/media/renderers/skcanvas_video_renderer.h
[modify] https://crrev.com/ecb97fdbc7b5f0d11835455699b32243de517b73/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

Cc: mkwst@chromium.org
Thank you for reporting and reverting. According to https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/54356/steps/cc_unittests%20on%20Windows-7-SP1/logs/stdio
It crash in only Win7.
e.g. [2959/2959] GLRendererPixelTest.NonPremultipliedTextureWithBackground (CRASHED)
Retrying 7 tests (retry #2)
[ RUN      ] VideoGLRendererPixelTest.TwoColorY16Rect


Could you Googler access crash log or stack trace? I read all the links but I could not find any stack trace.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 6 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Assigned (was: Untriaged)
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment