New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662368 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Grey Highlight of 'ADD PERSON' is seen overlapped with Account details section in chrome://md-settings

Project Member Reported by mmanchala@chromium.org, Nov 4 2016

Issue description

Version: 56.0.2908.0/8958.0.0 Cyan,Samus,Minnie
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User->Go to chrome://md-settings/accounts
(2)Now observe Grey Highlight of 'ADD PERSON' is seen overlapped with account details section(please refer screenshot)

Expected: No Overlapping should be seen with account details section
Actual: Instead Overlapping is seen

This is Non-Regression Issue seen from M-53
 
Actual_Overlapping.jpg
54.5 KB View Download

Comment 1 by dpa...@chromium.org, Nov 17 2016

Labels: Proj-MaterialDesign-WebUI
Cc: mahmadi@chromium.org tommycli@chromium.org
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
It doesn't appear to be overlapping, but might benefit from some extra padding. Pri-3

Comment 3 by bettes@chromium.org, Nov 28 2016

Owner: ----
Extra padding needed. You can use the 12px spec from dialogs. 

https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_dialogs.png%3Fz=width
Screen Shot 2016-11-28 at 10.10.20 AM.png
44.0 KB View Download

Comment 4 by bettes@chromium.org, Nov 28 2016

Status: Available (was: Assigned)
Labels: Hotlist-MD-Settings-PeopleCrOS
Labels: -M-56 -Pri-3 M-58 Pri-2
Owner: steve...@chromium.org
Status: Assigned (was: Available)
The UX for this has changed substantially (and looks correct), however I noticed a problem with inverted controls that I will fix here.

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa1515d170940a1887cf11a465068b82ea97e89d

commit fa1515d170940a1887cf11a465068b82ea97e89d
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Mar 02 18:14:32 2017

MD Settings: checkbox: Support inverted when setting pref

BUG= 662368 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2718253006
Cr-Commit-Position: refs/heads/master@{#454309}

[modify] https://crrev.com/fa1515d170940a1887cf11a465068b82ea97e89d/chrome/browser/resources/settings/controls/settings_boolean_control_behavior.js
[modify] https://crrev.com/fa1515d170940a1887cf11a465068b82ea97e89d/chrome/test/data/webui/settings/settings_toggle_button_tests.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
59.0.3054.0/9409.0.0

Sign in to add a comment