New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662366 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Unable to add person in chrome://md-settings/accounts using 'Enter' button from Keyboard

Project Member Reported by mmanchala@chromium.org, Nov 4 2016

Issue description

Version: 56.0.2908.0/8958.0.0 Cyan,Samus,Minnie
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User->Go to chrome://md-settings/accounts->Check 'Restrict sign-in to the following users' checkbox
(2)Now click on 'ADD PERSON' Button and add any Account->Click on 'Enter' button from keyboard and observe(Please refer Video)

Expected: On hitting Enter Button person should get added
Actual: Instead unable to add person

This is Regression Issue as same is working fine in chrome://settings page
 
Actual_EnterButton.webm
1.8 MB View Download
Expected_Enter.webm
703 KB View Download

Comment 1 by dpa...@chromium.org, Nov 15 2016

Labels: Proj-MaterialDesign-WebUI
Owner: tbuck...@chromium.org
Status: Assigned (was: Untriaged)
Cc: dbeam@chromium.org steve...@chromium.org
Labels: Hotlist-MD-Settings-PeopleCrOS
Owner: mahmadi@chromium.org
Looks like we need to support enter for form submission.
Owner: tommycli@chromium.org
Assigning to tommy.
Cc: scottchen@chromium.org
Owner: scottchen@chromium.org
Status: Started (was: Assigned)
Owner: tommycli@chromium.org
Status: Available (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ec6daa43735dfda250f19510fefb8b302e9bafe

commit 0ec6daa43735dfda250f19510fefb8b302e9bafe
Author: tommycli <tommycli@chromium.org>
Date: Wed Nov 30 19:55:06 2016

MD Settings: Listen to the Enter key in the Add User ChromeOS dialog.

Adds the Enter key listener in the same way as the Add Site dialog.
This uses the iron-a11y-keys method.

BUG= 662366 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2533173002
Cr-Commit-Position: refs/heads/master@{#435387}

[modify] https://crrev.com/0ec6daa43735dfda250f19510fefb8b302e9bafe/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/0ec6daa43735dfda250f19510fefb8b302e9bafe/chrome/browser/resources/settings/people_page/users_add_user_dialog.js

Status: Fixed (was: Available)
Status: Verified (was: Fixed)
Verified on ChromeOS 9077.0.0, 57.0.2948.0

Sign in to add a comment