New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662365 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Regression : In omnibox, 'Lock' icon is not seen properly (i.e the icon is not sharp enough) for any secure web page.

Reported by yfulgaon...@etouch.net, Nov 4 2016

Issue description

Chrome Version : 56.0.2909.0 (Official Build) 57c0a6fdc6a530bcb43f6657a8cf708752adca66-refs/heads/master@{#429737} 64-bit
OS : Mac(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch Chrome and navigate to https://google.com
2. Observe the lock icon on the LHS of omnibox. 

Actual : Lock icon is not seen properly i.e the icon is not sharp enough.
Expected : Lock icon should be sharp and appear properly.

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info.
Good build : 56.0.2908.0
Bad build : 56.0.2909.0

Note : Issue is seen only on Mac mini (10.10.5, 10.11.4) machines having ‘1366 x 768’ display resolution.
 
Act_Exp_lock_icon.png
27.0 KB View Download
Cc: lgar...@chromium.org
Labels: hasbisect
Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)
Unable to narrow down the range using tool as this issue is not reproducible on chromium builds, hence providing the suspect from change log.

Change log URL : 
https://chromium.googlesource.com/chromium/src/+log/56.0.2908.0..56.0.2909.0?pretty=fuller&n=10000

Suspecting : r 429658 or 429665 ? from Change log.

@spqchan : Please take a look.

Note : Issue is not seen on Windows and Linux OS.
Labels: ReleaseBlock-Stable
Stable blocker (visual regression), probably not beta blocker though I'm open to discussion. 
I am seeing this e.g. as well with the i-icon and the magnifying glass icon. Screenshots are attached. I am using a non-retina Macbook Air.
i-icon.png
7.7 KB View Download
magnifying glass icon.png
7.2 KB View Download
It's likely that this is caused by r429658

I'll look into this
Cc: spqc...@chromium.org emilyschechter@chromium.org elawrence@chromium.org est...@chromium.org
 Issue 663682  has been merged into this issue.
Friendly ping to get an update on this issue.

Thanks,
Status: Started (was: Assigned)
Fix in review: https://codereview.chromium.org/2503713002/
Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-56
Status: Started (was: Fixed)

Comment 12 by dimu@chromium.org, Nov 19 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 21 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4f0c7b3e73f274c4606f201385539d328e1f5da

commit d4f0c7b3e73f274c4606f201385539d328e1f5da
Author: spqchan <spqchan@chromium.org>
Date: Mon Nov 21 18:55:56 2016

[Mac] Fix for omnibox lock icon

- Align the permission bubble to be below the Lock Icon
- Fix blurry lock icon

BUG= 662411 ,  662365 

Review-Url: https://codereview.chromium.org/2503713002
Cr-Commit-Position: refs/heads/master@{#433283}
(cherry picked from commit f1b792a63088465603c079e7dc1037acb2b67427)

Review URL: https://codereview.chromium.org/2521033002 .

Cr-Commit-Position: refs/branch-heads/2924@{#32}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/d4f0c7b3e73f274c4606f201385539d328e1f5da/chrome/browser/ui/cocoa/location_bar/image_decoration.mm
[modify] https://crrev.com/d4f0c7b3e73f274c4606f201385539d328e1f5da/chrome/browser/ui/cocoa/location_bar/image_decoration_unittest.mm
[modify] https://crrev.com/d4f0c7b3e73f274c4606f201385539d328e1f5da/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Status: Fixed (was: Started)
Labels: -Merge-TBD
Already merged, removing TBD.
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 16 2016

Labels: Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 16 2016

This bug requires manual review: No test file found in commits.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 18 by dimu@google.com, Dec 16 2016

Labels: -Merge-Review-56 -Hotlist-Merge-Review
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review

Sign in to add a comment