New issue
Advanced search Search tips

Issue 662360 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ASAN/MSAN failures in virtual/mojo-loading/.../xmlhttprequest.

Project Member Reported by mkwst@chromium.org, Nov 4 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8026ba04bdc342c02fddee6dc230ac0aca9a1eae

commit 8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Author: yhirano <yhirano@chromium.org>
Date: Wed Nov 09 05:41:39 2016

Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG= 659917 ,  662360 

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Review-Url: https://codereview.chromium.org/2463753002
Cr-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Commit-Position: refs/heads/master@{#430874}

[modify] https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae/content/child/url_response_body_consumer.cc
[modify] https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/README.txt

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5

commit 83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5
Author: lukasza <lukasza@chromium.org>
Date: Wed Nov 09 17:54:57 2016

Revert of Add virtual tests for XHR with mojo-loading (patchset #9 id:160001 of https://codereview.chromium.org/2463753002/ )

Reason for revert:
The new tests fail when OOPIFs (out of process iframes / aka remote frames) are possible and turn the Site Isolation Win bot red.  Most likely failure modes differ between --site-per-process mode and the expectations landed in this CL in third_party/WebKit/LayoutTests/TestExpectations (so maybe the experimental feature needs to also maintain a separate set of test expectations in third_party/WebKit/LayoutTests/FlagExpectations/site-per-process).

Example red build: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/16899

Original issue's description:
> Add virtual tests for XHR with mojo-loading
>
> This CL adds virtual XHR tests with mojo-loading as
> virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
> failures. We add them to TestExpectations and will fix them later.
>
> BUG= 659917 ,  662360 
>
> Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
> Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
> Cr-Original-Commit-Position: refs/heads/master@{#429808}
> Cr-Commit-Position: refs/heads/master@{#430874}

TBR=tzik@chromium.org,nasko@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 659917 ,  662360 

Review-Url: https://codereview.chromium.org/2493503002
Cr-Commit-Position: refs/heads/master@{#430970}

[modify] https://crrev.com/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5/content/child/url_response_body_consumer.cc
[modify] https://crrev.com/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/83cd4c25b6cc96731b0f028a5b71baf2d3a74dd5/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/web-apps/README.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a474c91a2696cbb9cd57b6462e2252e7db6afd78

commit a474c91a2696cbb9cd57b6462e2252e7db6afd78
Author: yhirano <yhirano@chromium.org>
Date: Thu Nov 10 05:57:45 2016

Add virtual tests for XHR with mojo-loading

This CL adds virtual XHR tests with mojo-loading as
virtual/mojo-loading/http/tests/xmlhttprequest. Currently there are a lot of
failures. We add them to TestExpectations and will fix them later.

BUG= 659917 ,  662360 

Committed: https://crrev.com/0913b860b23efa2e60e45db579299da6a2618a2a
Committed: https://crrev.com/8026ba04bdc342c02fddee6dc230ac0aca9a1eae
Review-Url: https://codereview.chromium.org/2463753002
Cr-Original-Original-Commit-Position: refs/heads/master@{#429808}
Cr-Original-Commit-Position: refs/heads/master@{#430874}
Cr-Commit-Position: refs/heads/master@{#431191}

[modify] https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78/content/child/url_response_body_consumer.cc
[modify] https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/a474c91a2696cbb9cd57b6462e2252e7db6afd78/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/xmlhttprequest/README.txt

Sign in to add a comment