New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662337 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 529289



Sign in to add a comment

Drop support for PasswordManagerSettingsBehaviourChange

Project Member Reported by vabr@chromium.org, Nov 4 2016

Issue description

PasswordManagerSettingsBehaviourChange is a currently sleeping experiment related to the launch bug 529289.

The experiment is about changing the effect of the password manager setting: currently the setting controls saving of passwords only, filling works all the time (as long as some passwords have been stored previously). The new behaviour was meant to be controlling both saving and filling.

It is not clear if and when this experiment gets revived, so we should clean-up the code. If we need it back, we should make it a base::Feature in components/password_manager/core/common/password_manager_features.* anyway.

The only place where this experiment seemed to have controlled the code is in ChromePasswordManagerClient::IsFillingEnabledForCurrentPage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92648c89f03ae89685270ef2201a54a4a4155be3

commit 92648c89f03ae89685270ef2201a54a4a4155be3
Author: vabr <vabr@chromium.org>
Date: Fri Nov 04 15:17:19 2016

Remove experiment support for PasswordManagerSettingsBehaviourChange

The CL also fixes what appears to be a typo in PasswordManagerSettingsMigrationExperimentTest.IsSettingsMigrationOff: the call to EnforcePasswordManagerSettingsBehaviourChangeExperimentGroup should be a call to EnforcePasswordManagerSettingMigrationExperimentGroup.

BUG= 662337 

Review-Url: https://codereview.chromium.org/2472363002
Cr-Commit-Position: refs/heads/master@{#429888}

[modify] https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3/chrome/browser/ui/passwords/manage_passwords_view_utils_desktop_unittest.cc
[modify] https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3/components/password_manager/core/browser/password_manager_settings_migration_experiment.cc
[modify] https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3/components/password_manager/core/browser/password_manager_settings_migration_experiment.h
[modify] https://crrev.com/92648c89f03ae89685270ef2201a54a4a4155be3/components/password_manager/core/browser/password_manager_settings_migration_experiment_unittest.cc

Comment 2 by vabr@chromium.org, Nov 4 2016

Status: Fixed (was: Started)

Sign in to add a comment