Issue 662313 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ chuntsen@chromium.org Last visit > 30 days ago
Closed:	Nov 2016
Cc:	hungte@chromium.org
Components:	Factory
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
merge-merged-factory-gru-8652.B VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Factory install shim reboot after select S(Shell) action on gru

Project Member Reported by chuntsen@chromium.org, Nov 4 2016

Issue description

Factory install shim reboot after select S(Shell) action on gru.

Install shim try to bring up network before open shell, and call bringup_network().
However, bringup_network() use "find" which Gru do not contain, and reboot after error.

Comment 1 by hungte@chromium.org, Nov 4 2016

Components: Factory
Labels: OS-Chrome

Slightly different.

find is now installed by sys-apps/findutils. Unfortunately factory shims didn't list that in package dependency.

So the bringup_network was actually not installing any modules - at least not for factory shims (I think it works on netboot images).

In the meantime there's a bug in Gru images. The kernel/drivers/net/wireless-*/mac80211_hwsim may cause reboot when we do modprobe.

As a result, what we should do is
 (1) fix find to make it always available
 (2) change the modprobe stuff so it won't touch modules not needed.

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory_installer/+/9d9081718d89a7c257094f88406a2056718e55e3

commit 9d9081718d89a7c257094f88406a2056718e55e3
Author: chuntsen <chuntsen@google.com>
Date: Fri Nov 04 06:47:01 2016

Factory install shim: Fix the bug when trying to bring up network

Not every kernel modules can be loaded (mobprobe) successfully in
factory shim environment. We want to load only USB ethernet modules
for network bringup.

BUG= chromium:662313 
TEST=build install shim and open shell

Change-Id: I38227a65f8dab3f9456308710fcd56c7be997fb2
Reviewed-on: https://chromium-review.googlesource.com/407717
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Commit-Queue: Chun-Tsen Kuo <chuntsen@chromium.org>

[modify] https://crrev.com/9d9081718d89a7c257094f88406a2056718e55e3/ping_shopfloor.sh

Comment 3 by chuntsen@chromium.org, Nov 7 2016

Status: Fixed (was: Started)

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2016

Labels: merge-merged-factory-gru-8652.B

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory_installer/+/8d598885e265b5beba23dfcfcd0af8ac3d1e73cf

commit 8d598885e265b5beba23dfcfcd0af8ac3d1e73cf
Author: chuntsen <chuntsen@google.com>
Date: Fri Nov 04 06:47:01 2016

Factory install shim: Fix the bug when trying to bring up network

Not every kernel modules can be loaded (mobprobe) successfully in
factory shim environment. We want to load only USB ethernet modules
for network bringup.

BUG= chromium:662313 
TEST=build install shim and open shell

Reviewed-on: https://chromium-review.googlesource.com/407717
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Commit-Queue: Chun-Tsen Kuo <chuntsen@chromium.org>

(cherry picked from commit 9d9081718d89a7c257094f88406a2056718e55e3)

Change-Id: Idd3d2e6e9c0dec6fffc5738a68edcf151aff55ad
Reviewed-on: https://chromium-review.googlesource.com/408039
Reviewed-by: Chun-Tsen Kuo <chuntsen@chromium.org>
Commit-Queue: Chun-Tsen Kuo <chuntsen@chromium.org>
Tested-by: Chun-Tsen Kuo <chuntsen@chromium.org>

[modify] https://crrev.com/8d598885e265b5beba23dfcfcd0af8ac3d1e73cf/ping_shopfloor.sh