New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662305 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Print Preview crashes on rotating the preview in 'Clockwise' direction.

Reported by yfulgaon...@etouch.net, Nov 4 2016

Issue description

Chrome Version : 56.0.2909.0 (Official Build) 57c0a6fdc6a530bcb43f6657a8cf708752adca66-refs/heads/master@{#429737} 64-bit
OS : Mac(10.10.5, 10.11.4, 10.11.5)

Test URL : https://www.google.com/intl/en/chrome/browser/welcome.html

What steps will reproduce the problem?
1. Launch Chrome and navigate to above URL and hit ‘Cmd + P’.
2. In Print Preview window, right click on ‘Fit to Page’ button and select ‘Reload Frame’ option.
3. Now right click on print preview page and select ‘Rotate Clockwise’ option, observe the page.

Actual : Print preview crashes on rotating the preview in clockwise direction.
Expected : Print preview should not crash on rotating the preview in clockwise direction.

Crash ID : a5601381-024f-425b-8ac2-a396a9d05193 (Server ID: fbdc995700000000)

This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info.
Good build : 56.0.2908.0
Bad build : 56.0.2909.0

Note : Print Preview crash is also seen on ‘chrome://settings' and ‘chrome://history' pages.
 
Actual_Print.mov
6.8 MB Download
Expec_print.mov
5.7 MB Download
Update : 
Above issue is also seen on any pdf page as well. In case of pdf, both the print preview and pdf page crashes.
Kindly review an attached screen cast.
Pdf_print_preview.mov
2.8 MB Download
Cc: thestig@chromium.org brajkumar@chromium.org art-sn...@yandex-team.ru
Labels: ReleaseBlock-Stable
Owner: rsesek@chromium.org
Status: Assigned (was: Unconfirmed)
Stack Trace:
--------------
Thread 0 CRASHED [EXC_BAD_ACCESS / KERN_INVALID_ADDRESS @ 0x00000090 ] MAGIC SIGNATURE THREAD
Stack Quality78%Show frame trust levels
0x000000010b995bb0	(Google Chrome Framework -chunk_stream.h:86 )	chrome_pdf::DocumentLoader::IsDocumentComplete() const
0x000000010b9a9eae	(Google Chrome Framework -pdfium_engine.cc:2604 )	chrome_pdf::PDFiumEngine::LoadPageInfo(bool)
0x000000010b9aed91	(Google Chrome Framework -pdfium_engine.cc:2223 )	chrome_pdf::PDFiumEngine::InvalidateAllPages()
0x000000010b9aec6f	(Google Chrome Framework -pdfium_engine.cc:3422 )	chrome_pdf::PDFiumEngine::RotateInternal()
0x000000010b99e65f	(Google Chrome Framework -out_of_process_instance.cc:1263 )	chrome_pdf::(anonymous namespace)::Transform(int, PP_PrivatePageTransformType)
0x000000010907d1ac	(Google Chrome Framework -proxy_lock.h:135 )	ppapi::proxy::PPP_Pdf_Proxy::OnPluginMsgRotate(int, bool)
0x000000010907d097	(Google Chrome Framework -tuple.h:144 )	bool IPC::MessageT<PpapiMsg_PPPPdf_Rotate_Meta, std::__1::tuple<int, bool>, void>::Dispatch<ppapi::proxy::PPP_Pdf_Proxy, ppapi::proxy::PPP_Pdf_Proxy, void, void (ppapi::proxy::PPP_Pdf_Proxy::*)(int, bool)>(IPC::Message const*, ppapi::proxy::PPP_Pdf_Proxy*, ppapi::proxy::PPP_Pdf_Proxy*, void*, void (ppapi::proxy::PPP_Pdf_Proxy::*)(int, bool))
0x000000010907cf42	(Google Chrome Framework -ppp_pdf_proxy.cc:80 )	ppapi::proxy::PPP_Pdf_Proxy::OnMessageReceived(IPC::Message const&)
0x000000010905b521	(Google Chrome Framework -plugin_dispatcher.cc:252 )	ppapi::proxy::PluginDispatcher::OnMessageReceived(IPC::Message const&)
0x000000010874301a	(Google Chrome Framework -ipc_channel_proxy.cc:339 )	IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&)
0x0000000107d1b558	(Google Chrome Framework -callback.h:47 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x0000000107d3ec25	(Google Chrome Framework -message_loop.cc:413 )	base::MessageLoop::RunTask(base::PendingTask*)
0x0000000107d3eefb	(Google Chrome Framework -message_loop.cc:422 )	base::MessageLoop::DeferOrRunPendingTask(base::PendingTask)
0x0000000107d3f242	(Google Chrome Framework -message_loop.cc:515 )	base::MessageLoop::DoWork()
0x0000000107d418cc	(Google Chrome Framework -message_pump_mac.mm:330 )	base::MessagePumpCFRunLoopBase::RunWork()
0x0000000107d34009	(Google Chrome Framework + 0x01859009 )	base::mac::CallWithEHFrame(void () block_pointer)
0x0000000107d412e3	(Google Chrome Framework -message_pump_mac.mm:306 )	base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
0x00007fff960a4880	(CoreFoundation + 0x000aa880 )	__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__
0x00007fff96083fbb	(CoreFoundation + 0x00089fbb )	__CFRunLoopDoSources0
0x00007fff960834de	(CoreFoundation + 0x000894de )	__CFRunLoopRun
0x00007fff96082ed7	(CoreFoundation + 0x00088ed7 )	CFRunLoopRunSpecific
0x0000000107d41cae	(Google Chrome Framework -message_pump_mac.mm:554 )	base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*)
0x0000000107d4172b	(Google Chrome Framework -message_pump_mac.mm:238 )	base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
0x0000000107d5c932	(Google Chrome Framework -run_loop.cc:35 )	base::RunLoop::Run()
0x00000001077a3510	(Google Chrome Framework -ppapi_plugin_main.cc:157 )	content::PpapiPluginMain(content::MainFunctionParams const&)
0x00000001078ca8cc	(Google Chrome Framework -content_main_runner.cc:776 )	content::ContentMainRunnerImpl::Run()
0x00000001078c9b55	(Google Chrome Framework -content_main.cc:20 )	content::ContentMain(content::ContentMainParams const&)
0x00000001064ddeab	(Google Chrome Framework -chrome_main.cc:97 )	ChromeMain
0x00000001062a6da9	(Google Chrome Helper -chrome_exe_main_mac.c:85 )	main
0x00007fff86e495ac	(libdyld.dylib + 0x000035ac )	start
0x00007fff86e495ac	(libdyld.dylib + 0x000035ac )	start

Bisect Information:
------------------------
You are probably looking for a change made after 429513 (known good), but no later than 429514 (first known bad).

CHANGELOG URL:
----------------
https://chromium.googlesource.com/chromium/src/+log/a8b605106b36ad73ed37fe3a7bded7f631ac014c..3704ccf02007dd912933abc3f3006159171bc41b

From the CL above, assigning the issue to the concern owner 

Unable to find the authors name in the owners list, so assigning to the reviewers of the file for more updates.
Labels: hasbisect-per-revision
Labels: OS-Linux OS-Windows
Cc: pinkerton@chromium.org
Owner: ----
I'm not the author of this CL. art-snake@ is but I cannot assign it to them.
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 4 2016

Labels: FoundIn-M-56 Fracas
Users experienced this crash on the following builds:

Mac Canary 56.0.2909.0 -  1.80 CPM, 1 reports, 1 clients (signature chrome_pdf::DocumentLoader::IsDocumentComplete)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Status: Started (was: Assigned)
Fix is in https://codereview.chromium.org/2482533003/

I should disable that reload frame option inside of print preview...
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2673f9d15761c1e6e7c73d33079391df5911016

commit b2673f9d15761c1e6e7c73d33079391df5911016
Author: art-snake <art-snake@yandex-team.ru>
Date: Sat Nov 05 01:52:26 2016

Fix crash in Print Preview on rotating the preview in 'Clockwise' direction..

BUG= 662305 

Review-Url: https://codereview.chromium.org/2482533003
Cr-Commit-Position: refs/heads/master@{#430123}

[modify] https://crrev.com/b2673f9d15761c1e6e7c73d33079391df5911016/pdf/pdfium/pdfium_engine.cc

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a1fd28e635fd50afa36d5f8e4d4e4e4e4912292

commit 6a1fd28e635fd50afa36d5f8e4d4e4e4e4912292
Author: thestig <thestig@chromium.org>
Date: Mon Nov 07 22:27:22 2016

Prevent reloading the PDF embedded in the print preview.

BUG= 662305 

Review-Url: https://codereview.chromium.org/2480033002
Cr-Commit-Position: refs/heads/master@{#430399}

[modify] https://crrev.com/6a1fd28e635fd50afa36d5f8e4d4e4e4e4912292/chrome/browser/renderer_context_menu/render_view_context_menu.cc

Sign in to add a comment