Show "Login not secure" warning message for password and credit card forms on http websites on Clank. https://docs.google.com/document/d/1xno6g6OnA7strcyzE-o_drevW8L0Mb6ZBEkjsiwa6x0/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b928f12db89f12ed5c1911859080318ca21172eb commit b928f12db89f12ed5c1911859080318ca21172eb Author: lshang <lshang@chromium.org> Date: Sat Nov 05 04:35:06 2016 HTTP Bad: Add a switch for showing both verbose state and form warning This CL introduces a new switch kMarkHttpWithPasswordsOrCcWithChipAndFormWarning that enables both the omnibox warning and the autofill dropdown warning in HTTP Bad. That way, in case there are problems, we can launch the omnibox warning without the autofill dropdown warning via Finch. BUG= 662298 , 662297 Review-Url: https://codereview.chromium.org/2472943004 Cr-Commit-Position: refs/heads/master@{#430151} [modify] https://crrev.com/b928f12db89f12ed5c1911859080318ca21172eb/chrome/app/generated_resources.grd [modify] https://crrev.com/b928f12db89f12ed5c1911859080318ca21172eb/chrome/browser/about_flags.cc [modify] https://crrev.com/b928f12db89f12ed5c1911859080318ca21172eb/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc [modify] https://crrev.com/b928f12db89f12ed5c1911859080318ca21172eb/components/security_state/security_state_model.cc [modify] https://crrev.com/b928f12db89f12ed5c1911859080318ca21172eb/components/security_state/switches.cc [modify] https://crrev.com/b928f12db89f12ed5c1911859080318ca21172eb/components/security_state/switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/479fa58cbbb3b9234de6e53c05037afdfcf928d2 commit 479fa58cbbb3b9234de6e53c05037afdfcf928d2 Author: lshang <lshang@chromium.org> Date: Wed Nov 09 04:25:41 2016 HTTP Bad: Add warning message to autofill dropdown for http sites In HTTP Bad project, chrome will generally warn users for http websites which asks for credit cards and password info. Guarded by a switch flag kMarkHttpWithPasswordsOrCcWithChipAndFormWarning, this CL adds a warning message "Login not secure" on top of password suggestions in autofill popup dropdown. Will polish its styles and add icons in the following CLs. BUG= 662298 , 662297 Review-Url: https://codereview.chromium.org/2478043002 Cr-Commit-Position: refs/heads/master@{#430858} [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/DEPS [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_external_delegate.h [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_external_delegate_unittest.cc [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/autofill_strings.grdp [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/password_manager/core/browser/BUILD.gn [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/password_manager/core/browser/DEPS [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/479fa58cbbb3b9234de6e53c05037afdfcf928d2/components/password_manager/core/browser/password_autofill_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d6fb24de5f4de7bf92ca572b7be8c3a05376043 commit 4d6fb24de5f4de7bf92ca572b7be8c3a05376043 Author: lshang <lshang@chromium.org> Date: Fri Nov 18 04:14:56 2016 Http Bad: Add a PopupItemId to identify http warning message Since Http bad warning message has somewhat different UI from other autofill popup items (see specs of http bad warning message in: go/fns-ui-spec), this CL adds a new PopupItemId POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE to identify http warning message. And renamed POPUP_ITEM_ID_WARNING_MESSAGE to POPUP_ITEM_ID_INSECURE_CONTEXT_PAYMENT_DISABLED_MESSAGE accordingly to be more specific. This CL also changes text color of the message to show an example of use this new PopupItemId in UI code. BUG= 662298 , 662297 Review-Url: https://codereview.chromium.org/2496683003 Cr-Commit-Position: refs/heads/master@{#433092} [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/autofill/autofill_popup_layout_model.h [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/autofill/popup_constants.h [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [add] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/android/java/res/values/colors.xml [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/android/java/res/values/dimens.xml [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/core/browser/autofill_external_delegate_unittest.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/autofill/core/browser/popup_item_ids.h [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/content/public/android/java/src/org/chromium/content/browser/input/SelectPopupItem.java [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/ui/android/BUILD.gn [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/ui/android/java/res/layout/dropdown_item.xml [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/ui/android/java/res/values/dimens.xml [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/ui/android/java/src/org/chromium/ui/DropdownAdapter.java [modify] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/ui/android/java/src/org/chromium/ui/DropdownItem.java [add] https://crrev.com/4d6fb24de5f4de7bf92ca572b7be8c3a05376043/ui/android/java/src/org/chromium/ui/DropdownItemBase.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4 commit 9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4 Author: lshang <lshang@chromium.org> Date: Wed Nov 30 09:14:28 2016 Http Bad: Add icons to the http warning message For http sites, show gfx::VectorIconId::LOCATION_BAR_HTTP. For broken https, show gfx::VectorIconId::LOCATION_BAR_HTTPS_INVALID icon. BUG= 662298 , 662297 Review-Url: https://codereview.chromium.org/2498503002 Cr-Commit-Position: refs/heads/master@{#435195} [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/chrome/browser/android/resource_id.h [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/chrome/browser/ui/autofill/autofill_popup_layout_model.h [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/9c5dad4bc57d0d53a43bf5fabea8ff3a64a650e4/components/resources/autofill_scaled_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882 commit b0cb5e4ea319515a8de9c9e9720fd9a79beeb882 Author: lshang <lshang@chromium.org> Date: Wed Nov 30 11:53:50 2016 Http Bad: Add "Learn more" sublabel to warning message and make it clickable This CL adds a "Learn more" sublabel to the http bad warning message, and makes the dropdown item to be clickable and redirect to the security indicator help center page. BUG= 662298 , 662297 Review-Url: https://codereview.chromium.org/2505533002 Cr-Commit-Position: refs/heads/master@{#435224} [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/android_webview/native/aw_autofill_client.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/android_webview/native/aw_autofill_client.h [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/autofill_client.h [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/autofill_external_delegate.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/autofill_external_delegate_unittest.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/test_autofill_client.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill/core/browser/test_autofill_client.h [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/autofill_strings.grdp [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/components/password_manager/core/browser/password_autofill_manager_unittest.cc [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/ios/chrome/browser/ui/autofill/autofill_client_ios.h [modify] https://crrev.com/b0cb5e4ea319515a8de9c9e9720fd9a79beeb882/ios/chrome/browser/ui/autofill/autofill_client_ios.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6070555569eaaa95f95c259542781c7ccc6e777 commit a6070555569eaaa95f95c259542781c7ccc6e777 Author: lshang <lshang@chromium.org> Date: Fri Dec 02 02:07:26 2016 Http Bad: Put icon on the left of warning message and make value and label in one line on Android The order of elements in http bad warning message is: icon, value, label. This CL puts icon on the left of autofill entry in an advised dropdown layout called dropdown_item_left_icon.xml. This CL also adjusts value and label to be in one line. specs: go/fns-ui-spec BUG= 662297 Review-Url: https://codereview.chromium.org/2510283002 Cr-Commit-Position: refs/heads/master@{#435823} [modify] https://crrev.com/a6070555569eaaa95f95c259542781c7ccc6e777/components/autofill/android/java/src/org/chromium/components/autofill/AutofillSuggestion.java [modify] https://crrev.com/a6070555569eaaa95f95c259542781c7ccc6e777/ui/android/java/res/layout/dropdown_item.xml [modify] https://crrev.com/a6070555569eaaa95f95c259542781c7ccc6e777/ui/android/java/res/values/dimens.xml [modify] https://crrev.com/a6070555569eaaa95f95c259542781c7ccc6e777/ui/android/java/src/org/chromium/ui/DropdownAdapter.java [modify] https://crrev.com/a6070555569eaaa95f95c259542781c7ccc6e777/ui/android/java/src/org/chromium/ui/DropdownItem.java [modify] https://crrev.com/a6070555569eaaa95f95c259542781c7ccc6e777/ui/android/java/src/org/chromium/ui/DropdownItemBase.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8edeaa9c328d890df581d29012f294f3ad38a29 commit a8edeaa9c328d890df581d29012f294f3ad38a29 Author: lshang <lshang@chromium.org> Date: Sun Dec 04 23:32:48 2016 HTTP Bad: Add a seperator between http warning message and other entries According to the mocks(go/fns-ui-spec), there should be a seperator between http warning message and other autofill entries. BUG= 662298 , 662297 Review-Url: https://codereview.chromium.org/2542593003 Cr-Commit-Position: refs/heads/master@{#436205} [modify] https://crrev.com/a8edeaa9c328d890df581d29012f294f3ad38a29/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/a8edeaa9c328d890df581d29012f294f3ad38a29/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/a8edeaa9c328d890df581d29012f294f3ad38a29/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/a8edeaa9c328d890df581d29012f294f3ad38a29/components/password_manager/core/browser/password_autofill_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/287e86e1c12c26ad850476f1410f2002b0521c8a commit 287e86e1c12c26ad850476f1410f2002b0521c8a Author: lshang <lshang@chromium.org> Date: Thu Jan 05 10:09:31 2017 HTTP Bad: set color of http_info/https_invalid icon on Android Regenerate vector icon's xml files from svg icon in go/ob-sec-assets and reflect their color as in goo.gl/1CUOLK. BUG= 662297 Review-Url: https://codereview.chromium.org/2548753002 Cr-Commit-Position: refs/heads/master@{#441616} [delete] https://crrev.com/eaff8e380fa4ef7ad90a5929eb35ce81df786f70/chrome/android/java/res/drawable/ic_info_outline_black.xml [add] https://crrev.com/287e86e1c12c26ad850476f1410f2002b0521c8a/chrome/android/java/res/drawable/ic_info_outline_grey.xml [delete] https://crrev.com/eaff8e380fa4ef7ad90a5929eb35ce81df786f70/chrome/android/java/res/drawable/ic_warning_black.xml [add] https://crrev.com/287e86e1c12c26ad850476f1410f2002b0521c8a/chrome/android/java/res/drawable/ic_warning_red.xml [modify] https://crrev.com/287e86e1c12c26ad850476f1410f2002b0521c8a/chrome/browser/android/resource_id.h
Mark this as fixed after base implementation. Other future improvements or bugs are tracked in separate issues.
Comment 1 by lshang@chromium.org
, Nov 4 2016