New issue
Advanced search Search tips

Issue 662294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.chrome.browser.permissions.GeolocationTest#testGeolocationWatchPersistenceOffAllowedDialog" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 4 2016

Issue description

"org.chromium.chrome.browser.permissions.GeolocationTest#testGeolocationWatchPersistenceOffAllowedDialog" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNycgsSBUZsYWtlImdvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIucGVybWlzc2lvbnMuR2VvbG9jYXRpb25UZXN0I3Rlc3RHZW9sb2NhdGlvbldhdGNoUGVyc2lzdGVuY2VPZmZBbGxvd2VkRGlhbG9nDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: dominickn@chromium.org
Status: Assigned (was: Untriaged)
try run at 2016-11-04 03:35:02 UTC	(milo)	patchset	linux_android_rel_ng	(reported in 662294)
try run at 2016-11-03 19:31:48 UTC	(milo)	patchset	linux_android_rel_ng	(reported in 662294)
try run at 2016-11-03 16:54:21 UTC	(milo)	patchset	linux_android_rel_ng	(reported in 662294)
try run at 2016-11-01 23:30:54 UTC	(milo)	patchset	linux_android_rel_ng

https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/174163
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/173756
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/173624
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/172281

All the same error

org.chromium.chrome.browser.permissions.GeolocationTest#testGeolocationWatchPersistenceOffAllowedDialog (run #1):
junit.framework.AssertionFailedError: Values did not match. Expected: false, actual: true
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:112)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:133)
	at org.chromium.chrome.browser.permissions.PermissionTestCaseBase.waitForCheckedState(PermissionTestCaseBase.java:249)
	at org.chromium.chrome.browser.permissions.PermissionTestCaseBase.replyToDialogAndWaitForUpdates(PermissionTestCaseBase.java:232)
	at org.chromium.chrome.browser.permissions.PermissionTestCaseBase.runAllowTest(PermissionTestCaseBase.java:180)
	at org.chromium.chrome.browser.permissions.GeolocationTest.runTest(GeolocationTest.java:48)
	at org.chromium.chrome.browser.permissions.GeolocationTest.testGeolocationWatchPersistenceOffAllowedDialog(GeolocationTest.java:222)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Labels: -Sheriff-Chromium
Disabling in https://codereview.chromium.org/2470043007
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd6faa2561ad1267377da57c076885531d9df119

commit fd6faa2561ad1267377da57c076885531d9df119
Author: tapted <tapted@chromium.org>
Date: Fri Nov 04 06:22:46 2016

Disable flaky GeolocationTest#testGeolocationWatchPersistenceOffAllowedDialog

BUG= 662294 
TBR=dominickn@chromium.org,tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2470043007
Cr-Commit-Position: refs/heads/master@{#429811}

[modify] https://crrev.com/fd6faa2561ad1267377da57c076885531d9df119/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5

commit c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5
Author: dominickn <dominickn@chromium.org>
Date: Tue Nov 29 20:41:53 2016

Deflake permission dialog + persistence toggle tests on Android.

These tests would flake through timing out while waiting for a switch to
be toggled. The toggle was triggered through a synthetic touch event
sent to the switch view. Observing the flake would reveal that the
switch stayed in its original position after the touch event was sent,
so the hypothesis is that the touch event was sent prior to the view
being ready to respond to it.

This CL deflakes the tests by replacing the touch event for triggering
the toggle with an explicit toggle() call on the SwitchCompat object.
This no longer simulates the user input, but the tests should now
reliably pass.

This CL also corrects the arguments used for
MediaTest#testCombinedPersistenceOffDialog to match those of
MediaTest#testMicrophonePersistenceOffDialog.

BUG= 662294 , 663677 , 668700 

Review-Url: https://codereview.chromium.org/2538603002
Cr-Commit-Position: refs/heads/master@{#435074}

[modify] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
[modify] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
[modify] https://crrev.com/c6f2275d2d7d1db5d194f46b4d08e37ebb2769b5/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java

Sign in to add a comment