New issue
Advanced search Search tips

Issue 662292 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

LayoutTest drag-over-iframe-invalid-source-crash.html fails on WebKit Linux Precise Leak

Project Member Reported by tapted@chromium.org, Nov 4 2016

Issue description

First failure

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1428
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_Leak/1428/layout-test-results/results.html

says for http/tests/misc/drag-over-iframe-invalid-source-crash.html

({"numberOfLiveActiveDOMObjects":[2,3],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,23],"numberOfLiveResources":[0,1]})

Suspect:

Delegate dragend to the correct frame's EventHandler.

Currently, most drag-and-drop events are correctly delegated to the
EventHandler of the frame that contains the events' target elements, in
EventHandler::updateDragAndDrop. However,
EventHandler::dragSourceEndedAt does not implement this delegation.  The
issue is visible to the Web in a subtle way -- the frame of the
EventHandler is used to populate the DragEvent's view, which is used to
compute the clientX and clientY attributes, which are user-visible.

This CL implements the delegation used by
MouseEventManager::dispatchDragSrcEvent, into
MouseEventManager::dispatchDragSrcEvent.

BUG= 618770 

Review-Url: https://codereview.chromium.org/2469863003
Cr-Commit-Position: refs/heads/master@{#429669}

I'm not confident enough to revert, but this needs to be disabled.

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/ has been red for 16 cycles.

Please investigate!
 
actually confidence went up and the warning in LeakExpecations sacred me off :). Reverting - sorry.
Looks like it passed in https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1444 - it's still running, but the log has

23:08:30.412 16133 worker/0 http/tests/misc/drag-over-iframe-invalid-source-crash.html started
23:08:30.589 16133 worker/0 http/tests/misc/drag-over-iframe-invalid-source-crash.html passed


Status: Fixed (was: Assigned)
Fixed in http://crrev.com/2471843005

Sign in to add a comment