New issue
Advanced search Search tips

Issue 662286 link

Starred by 2 users
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Allow add to homescreen and app banner language to be varied via Finch

Project Member Reported by dominickn@chromium.org, Nov 4 2016 
We want to experiment with different UI strings to see if changing the language for add to homescreen has an impact on click through rates and user comprehension of what add to homescreen is.

This means implementing the ability to query variations for a parameter to control the string, and passing that parameter through to Java to render the menu/dialog/banner.

Due to i18n requirements, the strings must be hardcoded into the binary and can't be sent through variations.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ed0bf37b68c2b997bf8648a2037a180ebecca30

commit 9ed0bf37b68c2b997bf8648a2037a180ebecca30
Author: dominickn <dominickn@chromium.org>
Date: Thu Nov 10 02:09:33 2016

Allow add to homescreen and app banner strings to be changed via variations.

This CL adds a variations key to change the language of add to
homescreen and app banners. This is to experiment with different strings
to see the impact on click-through rates and user comprehension of the
feature.

BUG= 662286 

Review-Url: https://codereview.chromium.org/2474353002
Cr-Commit-Position: refs/heads/master@{#431140}

[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/android/BUILD.gn
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBarAndroid.java
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/browser/android/banners/app_banner_manager_android.cc
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/browser/banners/app_banner_settings_helper.cc
[modify] https://crrev.com/9ed0bf37b68c2b997bf8648a2037a180ebecca30/chrome/browser/banners/app_banner_settings_helper.h

Comment 2 by dominickn@chromium.org, Nov 15 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1055c94a39ee3096f347bd1293a3742e77a0474c

commit 1055c94a39ee3096f347bd1293a3742e77a0474c
Author: dominickn <dominickn@chromium.org>
Date: Thu Mar 09 22:10:38 2017

Change "add shortcut" back to "add to homescreen" for the "ADD" language variant.

Experimental results have shown that using the string "Add" in the app
banner leads to an increase in CTR. However, "Add shortcut" in the menu
item reduces CTR compared to "Add to homescreen". This CL changes
"Add shortcut" back to "Add to homescreen" in the menu item when
variations specifies that the language should be "Add" in the app
banner.

BUG= 662286 

Review-Url: https://codereview.chromium.org/2738053003
Cr-Commit-Position: refs/heads/master@{#455877}

[modify] https://crrev.com/1055c94a39ee3096f347bd1293a3742e77a0474c/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
[modify] https://crrev.com/1055c94a39ee3096f347bd1293a3742e77a0474c/chrome/android/java/strings/android_chrome_strings.grd
►

Sign in to add a comment