New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662283 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

URL redirecting doesn't work

Project Member Reported by martiniss@chromium.org, Nov 4 2016

Issue description

From an email:

"Stephen, looks like a login redirect issue? The link on the sheriffing page is https://sheriff-o-matic.appspot.com/chromium.perf, but I just clicked it and I get a login page and then it redirects and takes the "chromium.perf" part off my query.
"

I've experienced this a couple times. We should definitely fix this; if we put a link to SOM on a sheriffing doc page, and it doesn't redirect correctly, and they're unfamiliar with the tool, they could end up sheriffing the wrong tree.
 
Cc: sullivan@chromium.org
Components: Infra>Client>Perf

Comment 3 by benhenry@google.com, Nov 10 2016

Cc: jparent@chromium.org seanmccullough@chromium.org
Labels: -Pri-2 Pri-1
Status: Untriaged (was: Available)
This should be a simple fix with big impact now that there's multiple rotations. Can we get someone on this?
I'll look at this today.
Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
assigning to martiniss@ as he intends to look into it
Status: Started (was: Assigned)
Working on this. Small fix!
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/fb6cd3035cc307a93948a87be99320e24ece75c0

commit fb6cd3035cc307a93948a87be99320e24ece75c0
Author: Stephen Martinis <martiniss@chromium.org>
Date: Fri Dec 02 22:34:45 2016

SOM: redirect to original page when asked to login

BUG= 662283 

Change-Id: I79965de74b387f6b78be96558be4726b9e4743f4
Reviewed-on: https://chromium-review.googlesource.com/416372
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/fb6cd3035cc307a93948a87be99320e24ece75c0/go/src/infra/appengine/sheriff-o-matic/som/main.go

Status: Fixed (was: Started)

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment