New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662279 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 620662



Sign in to add a comment

Delete ReplicaInputConnection

Project Member Reported by aelias@chromium.org, Nov 4 2016

Issue description

Now that --use-ime-thread has shipped to 100% of users in M54, we can finally delete all the legacy code.  This bug is to track:

- Disabling the ReplicaInputConnection tests and deleting the test parametrization
- Deleting ReplicaInputConnection.java
- Deleting IME thread flag
- Deleting the finch trial
- Deleting the code that only runs in ReplicaInputConnection mode from ImeAdapter.java down to render_widget.cc

Marking as P3 as this cleanup can be performed gradually and fixing IME bugs should take priority over it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05

commit 38c3eb61c737a8d3313ca8cd31b0c514c9d35b05
Author: changwan <changwan@chromium.org>
Date: Fri Dec 09 01:45:56 2016

Remove deprecated ReplicaInputConnection

Since ImeThread and its ThreadedInputConnection implementation are rolled
out to stable, there is no need to keep ReplicaInputConnection and related
logics in renderer.

Note that this just removes dead code and is purely mechanical.
Polish up around ChangeSource will be handled in a separate CL.

BUG= 662279 

Review-Url: https://codereview.chromium.org/2553923002
Cr-Commit-Position: refs/heads/master@{#437422}

[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/build/android/lint/suppressions.xml
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/chrome/browser/about_flags.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/browser/renderer_host/ime_adapter_android.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/browser/renderer_host/ime_adapter_android.h
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/common/input_messages.h
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/public/android/BUILD.gn
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/public/android/java/src/org/chromium/content/browser/input/InputMethodUma.java
[delete] https://crrev.com/28c67cc03923f8a1dc3c15dd248c392c0ce989b3/content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/public/android/javatests/src/org/chromium/content/browser/input/ImeLollipopTest.java
[delete] https://crrev.com/28c67cc03923f8a1dc3c15dd248c392c0ce989b3/content/public/android/javatests/src/org/chromium/content/browser/input/ReplicaInputConnectionTest.java
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/public/common/content_features.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/renderer/ime_event_guard.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/renderer/render_widget.cc
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/content/renderer/render_widget.h
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[modify] https://crrev.com/38c3eb61c737a8d3313ca8cd31b0c514c9d35b05/third_party/WebKit/public/web/WebWidgetClient.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae

commit 75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae
Author: changwan <changwan@chromium.org>
Date: Mon Jan 16 02:55:00 2017

Clean up names and remove unnecessary parameter

is_non_ime_change and from_non_ime are difficult to understand - it's
negative and the meaning of non-ime change and from non-ime are unclear.
Also, !is_non_ime_change is a double negative and can be very confusing.

Replace these names by reply_to_request.
Also, reply_to_request is currently set only in
RenderWidget::OnRequestTextInputStateUpdate(). By having it call an internal
function, we can remove the parameter from all the other call sites.

Moreover, HIDE_IME is incorrectly named - it does not hide virtual keyboard.

And SHOW_IME and showImeIfNeeded() are mildly confusing - it may sound as
if it affected hardware keyboard but it is actually only concerned with
virtual keyboard. "IfNeeded" was added to stress the point that it only
affects virtual keyboard case. ImeOnFocusTest.cpp is easier to read after
this change.

By adding another function ShowVirtualKeyboard(), the call sites no longer
need to pass a parameter.

Note that showImeIfNeeded() and show_ime_if_needed in the message and
browser process have not changed yet. There are up to 100 files that
are affected, so I will separate them out as a single-themed change.

BUG= 662279 

Review-Url: https://codereview.chromium.org/2596193002
Cr-Commit-Position: refs/heads/master@{#443836}

[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/browser/android/content_view_core_impl.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/common/text_input_state.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/common/text_input_state.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/common/view_messages.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/test/text_input_test_utils.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/public/test/text_input_test_utils.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/ime_event_guard.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/ime_event_guard.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/input/render_widget_input_handler.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/input/render_widget_input_handler_delegate.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/mus/render_widget_mus_connection.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/mus/render_widget_mus_connection.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/render_view_impl.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/render_view_impl.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/render_widget.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/renderer/render_widget.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/content/test/layouttest_support.cc
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/Source/core/page/ChromeClient.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/Source/web/ChromeClientImpl.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/public/web/WebViewClient.h
[modify] https://crrev.com/75e3b207a503c0ad4ad141ca78b7cf4bd06da4ae/third_party/WebKit/public/web/WebWidgetClient.h

Comment 4 by aelias@chromium.org, Apr 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment