New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662272 link

Starred by 2 users
Status: Fixed
Owner:
calamity@chromium.org
Closed: Nov 2016
Cc:
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

'Remove from history' button is enabled for supervised users

Project Member Reported by calamity@chromium.org, Nov 4 2016 
The menu button in each history item is still enabled even if history deletion isn't allowed.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb

commit e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb
Author: calamity <calamity@chromium.org>
Date: Tue Nov 15 05:53:54 2016

[MD History] Disable menu button when history deletion is disabled.

This CL disables the 'Remove from history' button on the history item
menu when history deletion isn't allowed.

BUG= 662272 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2478773002
Cr-Commit-Position: refs/heads/master@{#432121}

[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/browser/resources/md_history/lazy_load.crisper.js
[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/e1232ea6226cd1bdfe1e7f9e89fd049dd4bbeecb/chrome/test/data/webui/md_history/history_supervised_user_test.js

Comment 2 by dbeam@chromium.org, Nov 15 2016 

fixed now?

Comment 3 by tsergeant@chromium.org, Nov 15 2016

Status: Fixed (was: Started)
Yup
►

Sign in to add a comment