New issue
Advanced search Search tips

Issue 662264 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Test .../sandbox-disallow-same-origin.html marked flaky in TestExpectations.

Project Member Reported by tapted@chromium.org, Nov 4 2016

Issue description

Rebaselined in r429698 "Import wpt@9fcccf38b6be00f71ffa6bd6e29c5aa1ef25ee8c"

From https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/5700/layout-test-results/results.html

Errors like
sandbox-allow-same-origin.html
CONSOLE ERROR: line 20: Uncaught TypeError: Cannot read property 'innerHTML' of null
This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = Uncaught TypeError: Cannot read property 'innerHTML' of null
NOTRUN DOM access in sandbox='allow-same-origin' iframe is allowed 
Harness: the test ran to completion.

form-action-url.html
This is a testharness.js-based test.
Harness Error. harness_status.status = 2 , harness_status.message = null
NOTRUN Submit a form from an iframe with a base url 
Harness: the test ran to completion.


Bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5700
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20%28dbg%29/builds/881
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7980


 
going to disable

imported/wpt/html/browsers/sandboxing/sandbox-allow-scripts.html
imported/wpt/html/browsers/sandboxing/sandbox-disallow-same-origin.html
imported/wpt/html/browsers/sandboxing/sandbox-allow-same-origin.html
imported/wpt/html/semantics/forms/the-form-element/form-action-url.html


Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84cb9a0368a313c32b100d3688f56b4488ef7e50

commit 84cb9a0368a313c32b100d3688f56b4488ef7e50
Author: tapted <tapted@chromium.org>
Date: Fri Nov 04 03:56:35 2016

Mark some Timeout imported/wpt/html LayoutTests as Failure also.

Failing since a rebaseline in r429698.

BUG= 662264 
TBR=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2476853002
Cr-Commit-Position: refs/heads/master@{#429778}

[modify] https://crrev.com/84cb9a0368a313c32b100d3688f56b4488ef7e50/third_party/WebKit/LayoutTests/TestExpectations

Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
One test left from the original four; uploaded CL:
https://codereview.chromium.org/2556163002
Labels: -OS-Linux -OS-Windows -Pri-1 -OS-Mac Pri-3
Summary: Test .../sandbox-disallow-same-origin.html marked flaky in TestExpectations. (was: LayoutTests form-action-url.html, sandbox-disallow-same-origin.html and related sandbox goo failing in various places)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d8ef24b4f241f165499751584bbbc0dfec51703

commit 5d8ef24b4f241f165499751584bbbc0dfec51703
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 11 22:04:56 2017

Remove sandbox-disallow-same-origin.html from TestExpectations.

This is the only test still listed in TestExpectations from  http://crbug.com/662264 ; I believe that it only times out now; I think it makes sense to just put it with the other similar imported tests that time out.

BUG= 662264 

Review-Url: https://codereview.chromium.org/2605363002
Cr-Commit-Position: refs/heads/master@{#443001}

[modify] https://crrev.com/5d8ef24b4f241f165499751584bbbc0dfec51703/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment