New issue
Advanced search Search tips

Issue 662246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 457449



Sign in to add a comment

IDBObservers: Add transaction support

Project Member Reported by dmu...@chromium.org, Nov 4 2016

Issue description

Blocking: 457449
Components: Blink>Storage>IndexedDB
Labels: dmurph-shortlist-features
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50ab051b3e40c25d39262bca9b71395d20632dc9

commit 50ab051b3e40c25d39262bca9b71395d20632dc9
Author: dmurph <dmurph@chromium.org>
Date: Tue Nov 29 22:13:30 2016

[IndexedDB] Integrating failures and corruption with transaction

R=cmumford@chromium.org
BUG= 363397 , 662246 

Review-Url: https://codereview.chromium.org/2506773002
Cr-Commit-Position: refs/heads/master@{#435089}

[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_factory_impl.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_fake_backing_store.h
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/50ab051b3e40c25d39262bca9b71395d20632dc9/content/browser/indexed_db/indexed_db_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d00e05d1070176eb8a13f7b83d73f067946f958

commit 9d00e05d1070176eb8a13f7b83d73f067946f958
Author: dmurph <dmurph@chromium.org>
Date: Thu Dec 01 23:00:34 2016

[IndexedDB] Refactoring to remove ref ptrs and host transaction ids.

R=cmumford
BUG=457449, 662246 

Review-Url: https://codereview.chromium.org/2472213003
Cr-Commit-Position: refs/heads/master@{#435749}

[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/cursor_impl.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/cursor_impl.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/database_impl.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_backing_store.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_backing_store.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_class_factory.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_class_factory.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_connection.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_connection.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_context_impl.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_cursor.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_cursor.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_database_callbacks.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_database_callbacks.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_database_unittest.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_dispatcher_host.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_dispatcher_host.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_factory_unittest.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_fake_backing_store.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_pending_connection.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_pending_connection.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_transaction_coordinator.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/indexed_db_transaction_unittest.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/mock_browsertest_indexed_db_class_factory.h
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/mock_indexed_db_database_callbacks.cc
[modify] https://crrev.com/9d00e05d1070176eb8a13f7b83d73f067946f958/content/browser/indexed_db/mock_indexed_db_database_callbacks.h

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1319a867978d9700653ecc5a6592d24b6367a2c

commit a1319a867978d9700653ecc5a6592d24b6367a2c
Author: dmurph <dmurph@chromium.org>
Date: Wed Jan 18 22:29:23 2017

[IndexedDB] Adding transaction and value support to observers

BUG= 662248 , 662246 ,609934
R=pwnall@chromium.org,jsbell@chromium.org,cmumford@chromium.org

Review-Url: https://codereview.chromium.org/2601983002
Cr-Commit-Position: refs/heads/master@{#444514}

[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_callbacks.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_callbacks.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_connection.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_connection.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_database.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_database.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_observer.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_transaction.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_transaction_coordinator.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/indexed_db_transaction_coordinator.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/list_set.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/browser/indexed_db/list_set_unittest.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/child/indexed_db/indexed_db_callbacks_impl.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/child/indexed_db/indexed_db_callbacks_impl.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/child/indexed_db/indexed_db_database_callbacks_impl.cc
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/content/common/indexed_db/indexed_db.mojom
[add] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/LayoutTests/storage/indexeddb/observer-transaction-test.html
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/LayoutTests/storage/indexeddb/observer.html
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-actions.js
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-tests.js
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer.js
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.cpp
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBObserverChanges.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h
[modify] https://crrev.com/a1319a867978d9700653ecc5a6592d24b6367a2c/third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseCallbacks.h

Comment 5 by dmu...@chromium.org, Jan 18 2017

Status: Fixed (was: Started)

Sign in to add a comment