New issue
Advanced search Search tips

Issue 662239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

Each Downloaded file is inserted into Downloads app twice on N+

Project Member Reported by qin...@chromium.org, Nov 4 2016

Issue description

this happens on dev for all N+ devices 


see internal b/32626669



 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cc70b6bdd6f8988ca39a33cde38e917f0e68162

commit 0cc70b6bdd6f8988ca39a33cde38e917f0e68162
Author: qinmin <qinmin@chromium.org>
Date: Fri Nov 04 02:29:28 2016

Fix a bug that downloaded file is added twice to Android DownloadManager on N+

BUG= 662239 

Review-Url: https://codereview.chromium.org/2476583003
Cr-Commit-Position: refs/heads/master@{#429769}

[modify] https://crrev.com/0cc70b6bdd6f8988ca39a33cde38e917f0e68162/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

Labels: Merge-Request-55
Status: Started (was: Unconfirmed)

Comment 3 by dimu@chromium.org, Nov 4 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 4 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/715daa6c95f6fe2ffd7d5e7f09fad6ee5f13c182

commit 715daa6c95f6fe2ffd7d5e7f09fad6ee5f13c182
Author: Min Qin <qinmin@chromium.org>
Date: Fri Nov 04 05:57:06 2016

Fix a bug that downloaded file is added twice to Android DownloadManager on N+

BUG= 662239 
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2476583003
Cr-Commit-Position: refs/heads/master@{#429769}
(cherry picked from commit 0cc70b6bdd6f8988ca39a33cde38e917f0e68162)

Review URL: https://codereview.chromium.org/2471283006 .

Cr-Commit-Position: refs/branch-heads/2883@{#449}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/715daa6c95f6fe2ffd7d5e7f09fad6ee5f13c182/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

Status: fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 4 2016

Labels: merge-merged-2906
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65849f37aa6ba6821cdb7faf1371d1e255c08823

commit 65849f37aa6ba6821cdb7faf1371d1e255c08823
Author: Alex Mineer <amineer@chromium.org>
Date: Fri Nov 04 18:37:31 2016

Fix a bug that downloaded file is added twice to Android DownloadManager on N+

BUG= 662239 

(cherry picked from commit 0cc70b6bdd6f8988ca39a33cde38e917f0e68162)

Review-Url: https://codereview.chromium.org/2476583003
Cr-Original-Commit-Position: refs/heads/master@{#429769}
Cr-Commit-Position: refs/branch-heads/2906@{#5}
Cr-Branched-From: 8d817067131214a7c5ea66b95b9aaa30f41f773f-refs/heads/master@{#428890}

[modify] https://crrev.com/65849f37aa6ba6821cdb7faf1371d1e255c08823/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java

Sign in to add a comment