[REGRESSION] DevTools: can't see text of selected comment nodes in Elements Panel. |
||||||
Issue descriptionRepro: 1. Open devtools on a page with HTML comments 2. Select a comment node in DOM tree 3. Observe. Expected: the comment text is white and readable. Actual: unreadable comment text. See screenshot for details. Offensive patch: https://codereview.chromium.org/2334073002
,
Nov 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edcbe5232d2874dbc727c35fd54824e5bd9642fa commit edcbe5232d2874dbc727c35fd54824e5bd9642fa Author: lushnikov <lushnikov@chromium.org> Date: Sat Nov 05 04:19:32 2016 DevTools: [Elements] fix text color of selected HTMLComment nodes This patch turns text color to white for selected HTMLComment nodes. BUG= 662226 R=dgozman, einbinder Review-Url: https://codereview.chromium.org/2472313002 Cr-Commit-Position: refs/heads/master@{#430148} [modify] https://crrev.com/edcbe5232d2874dbc727c35fd54824e5bd9642fa/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
,
Nov 15 2016
Verified working on Chrome Canary. Would be great to have this in M-55
,
Nov 15 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a20cbae210249f4bb446e749f129467d98189ab commit 6a20cbae210249f4bb446e749f129467d98189ab Author: Andrey Lushnikov <lushnikov@chromium.org> Date: Tue Nov 15 23:38:29 2016 DevTools: [Elements] fix text color of selected HTMLComment nodes This patch turns text color to white for selected HTMLComment nodes. BUG= 662226 R=dgozman, einbinder Review-Url: https://codereview.chromium.org/2472313002 Cr-Commit-Position: refs/heads/master@{#430148} (cherry picked from commit edcbe5232d2874dbc727c35fd54824e5bd9642fa) Review URL: https://codereview.chromium.org/2504013002 . Cr-Commit-Position: refs/branch-heads/2883@{#583} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/6a20cbae210249f4bb446e749f129467d98189ab/third_party/WebKit/Source/devtools/front_end/ui/inspectorSyntaxHighlight.css
,
Nov 15 2016
,
Nov 16 2016
Tested the issue on Ubuntu 14.04 using Chrome Beta# 55.0.2883.52 and observed that the comment text is readable. The Comment text is seen with BLUE background and WHITE text. Hence adding TE-Verified labels. Attaching a screen shot for reference. Thank You. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lushnikov@chromium.org
, Nov 4 2016