Issue metadata
Sign in to add a comment
|
[TTS] Quick answers broken on some builds |
||||||||||||||||||||||
Issue descriptionLooks like Quick Answers with Translation might be broken on M-56. I never see the caption show the translation. Sailaja, please ask someone to retest. There may be two issues: 1) caption doesn't show on Dev, 2) Translate onebox doesn't get triggered on Canary. Repro: just go to de.m.wikipedia.org and tap on almost any word. I expect to see the translation appear in the caption after a few seconds. Instead nothing appears. On Dev I do see the Translation Onebox in the SERP, so that means we triggered the translation and for some reason didn't show it client side. On Canary the Translation Onebox does not even show in the SERP, so the client may not be correctly identifying a language mismatch.
,
Nov 3 2016
,
Nov 3 2016
Could this have to do with changing the finch configs when we split for english vs non-english locales?
,
Nov 4 2016
Yes, being Finch-related or due to our recent config changes seems possible, but I doubt it because Dev and Beta have the same config and they work differently for me. When isolating this problem, there are three flags that may be useful to try: --enable_quick_answers (enables the caption) --enable_translation (enables the translation One-box, which when present feeds the caption) --enable_english_target_translation (enables using English as a target language even when the user has multiple languages, e.g. a keyboard) The first two should be on for everyone, the third on for US and GB but off everywhere else. You should be able to set any of these =true or =false to test.
,
Nov 5 2016
Looks like this is due to recent white-listing of mojo services, and we're not on the right whitelists. Matt helped me figure this out. It should be easy to add TTS to the whitelist and merge back.
,
Nov 7 2016
Tested on Nexus 7 / LRX22G and Lenovo K4 Note (A7010a48) / LMY47D Works fine on M54 Stable and M55 Beta. Broken on M56 Dev.
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/353fa4026777357872b64b66bb976f9d316e2c6d commit 353fa4026777357872b64b66bb976f9d316e2c6d Author: donnd <donnd@chromium.org> Date: Tue Nov 15 02:39:01 2016 [TTS] Fix Translation by whitelisting CS mojo services. Mojo services were recently whitelisted, which broke Contextual Search's usage for translation and quick answers. This CL adds Contextual Search to the content browser and content renderer mojo manifests in order to make them part of the whitelist. BUG= 662219 ,661118 Review-Url: https://codereview.chromium.org/2485983002 Cr-Commit-Position: refs/heads/master@{#432064} [modify] https://crrev.com/353fa4026777357872b64b66bb976f9d316e2c6d/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/353fa4026777357872b64b66bb976f9d316e2c6d/chrome/browser/chrome_content_renderer_manifest_overlay.json
,
Nov 21 2016
Hopefully the issue with Canary in #1 was just flakiness with Canary. Otherwise fixed. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsgav...@chromium.org
, Nov 3 2016