New issue
Advanced search Search tips

Issue 662216 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Provide specific problem before generic "LGTM from committers" error message

Project Member Reported by d...@chromium.org, Nov 3 2016

Issue description

I accidentally uploaded this patch to tools/build with my @google.com credentials instead of my @chromium.org credentials:

https://codereview.chromium.org/2475803002/

However, the error message that the CQ spat out was:

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

This does not apply, and completely points in the wrong direction. This should be fixed to correctly note that the uploading account does't have permission to run try/CQ jobs.
 
IMHO, the message already says that: "CQ run can only be started by full committers", i.e. "You are not a committer and don't have a permission to run a CQ". Can you please be more specific and write a full message that you think CQ should print?

Comment 2 by d...@chromium.org, Nov 4 2016

This message lists several possible problems:
- I need an LGTM from a valid reviewer? Confusing b/c I TBR'd.
- I am not a full committer?
- I need an LGTM from a full committer?
- Maybe I got an LGTM, but it was not from a full committer?

I think the CQ should post (or at least highlight) the actual immediate problem. In this case, the message should read something like:

Your account, "dnj@google.com", is not a committer account, so the CQ requires an explicit LGTM from a full committer.

Then you can tack on the generic message:

CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Summary: Provide specific problem before generic "LGTM from committers" error message (was: Really bad "LGTM from committers" error message for CLs with wrong account.)
Btw, this is Rietveld-only as of today, but we might end up re-using parts of LGTM verifier for Gerrit to support external contributors.
Components: -Infra>CQ Infra>Platform>CQdaemon

Comment 6 by efoo@chromium.org, Aug 31 2017

Components: Infra>Platform>CQ

Comment 7 by efoo@chromium.org, Aug 31 2017

Components: -Infra>Platform>CQdaemon
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Rietveld specific, we are using Gerrit now.

Sign in to add a comment