Provide specific problem before generic "LGTM from committers" error message |
|||||||
Issue descriptionI accidentally uploaded this patch to tools/build with my @google.com credentials instead of my @chromium.org credentials: https://codereview.chromium.org/2475803002/ However, the error message that the CQ spat out was: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files. This does not apply, and completely points in the wrong direction. This should be fixed to correctly note that the uploading account does't have permission to run try/CQ jobs.
,
Nov 4 2016
This message lists several possible problems: - I need an LGTM from a valid reviewer? Confusing b/c I TBR'd. - I am not a full committer? - I need an LGTM from a full committer? - Maybe I got an LGTM, but it was not from a full committer? I think the CQ should post (or at least highlight) the actual immediate problem. In this case, the message should read something like: Your account, "dnj@google.com", is not a committer account, so the CQ requires an explicit LGTM from a full committer. Then you can tack on the generic message: CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-infra-committers". Note that this has nothing to do with OWNERS files.
,
Nov 7 2016
,
Nov 7 2016
Btw, this is Rietveld-only as of today, but we might end up re-using parts of LGTM verifier for Gerrit to support external contributors.
,
Jan 23 2017
,
Aug 31 2017
,
Aug 31 2017
,
Aug 31
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 31
Rietveld specific, we are using Gerrit now. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by serg...@chromium.org
, Nov 4 2016