New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662211 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

build274-m2 has bad cache dir settings

Project Member Reported by vapier@chromium.org, Nov 3 2016

Issue description

log:
https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/full/builds/193

my CLs don't touch chromite or the Chrome sync path, but SyncChrome died:
OSError: [Errno 13] Permission denied: '/b/cbuild/external_master/.cache/distfiles/target-master/chrome-src'

assigning to deputy
 
Short term fix is in place. I just blew away that .cache directory.

However, we have a file permissions problem that needs a more permanent fix.
Status: Started (was: Unconfirmed)
Did you happen to check exactly which file in the path was root owned?

See https://chromium-review.googlesource.com/#/c/401998/ for a recent fix to an almost same problem. I want to know that that fix actually worked.

Also, the offending checkout path was recently changed: https://chromium-review.googlesource.com/#/c/403369/
The directory with the problem is the one listed in comment 0.

My fix is to improve our ChromeSync clobber code to cleanup as root. But that doesn't explain how the directories ended up root owned.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ad54ff297b1ab7e9932a8e625f1278f0c0b12565

commit ad54ff297b1ab7e9932a8e625f1278f0c0b12565
Author: Don Garrett <dgarrett@google.com>
Date: Fri Nov 04 19:38:13 2016

sync_chrome: Use root to clobber a bad checkout.

We clobber and retry the Chrome sync after an error to recover from
corruption. However, the clobber needs root to clean up files with the
wrong owner (which has somehow happened).

BUG= chromium:662211 
TEST=None

Change-Id: Iac3e3c5366faf028f74702de70b8a5d1264fbd17
Reviewed-on: https://chromium-review.googlesource.com/407960
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ad54ff297b1ab7e9932a8e625f1278f0c0b12565/scripts/sync_chrome.py

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 14 2016

Labels: merge-merged-factory-reef-8811.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a1486759cfc83e03f54765566d8eea6dfa1622fa

commit a1486759cfc83e03f54765566d8eea6dfa1622fa
Author: Don Garrett <dgarrett@google.com>
Date: Fri Nov 04 19:38:13 2016

sync_chrome: Use root to clobber a bad checkout.

We clobber and retry the Chrome sync after an error to recover from
corruption. However, the clobber needs root to clean up files with the
wrong owner (which has somehow happened).

BUG= chromium:662211 
TEST=None

Change-Id: Iac3e3c5366faf028f74702de70b8a5d1264fbd17
Reviewed-on: https://chromium-review.googlesource.com/407960
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit ad54ff297b1ab7e9932a8e625f1278f0c0b12565)
Reviewed-on: https://chromium-review.googlesource.com/419781
Tested-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org>
Commit-Queue: YH Lin <yueherngl@chromium.org>

[modify] https://crrev.com/a1486759cfc83e03f54765566d8eea6dfa1622fa/scripts/sync_chrome.py

Comment 8 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 9 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 10 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 11 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 13 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment