New issue
Advanced search Search tips

Issue 662208 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] clean up MediaRoute::Id usage in PresentationServiceDelegateImpl

Project Member Reported by zhaobin@chromium.org, Nov 3 2016

Issue description

In https://codereview.chromium.org/2471883002/ we return route instead of route_id for MR extension callbacks. We might be able to get rid of MediaRoute::Id usage (return MediaRoute object instead) in PresentationServiceDelegateImpl.


 

Comment 1 by sko...@chromium.org, Nov 10 2016

Labels: Hotlist-Fixit
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7419dd4ce85ab76c88a8a64e7805a07eb9dd7790

commit 7419dd4ce85ab76c88a8a64e7805a07eb9dd7790
Author: zhaobin <zhaobin@chromium.org>
Date: Fri Nov 18 23:09:13 2016

[Presentation API] cleanup: pass in MediaRoute instead of MediaRoute::Id to PresentationServiceDelegateImpl::OnPresentationSessionStarted()

Seperate CL to resolve code review comments in https://codereview.chromium.org/2471883002/

BUG= 662208 

Review-Url: https://codereview.chromium.org/2468363006
Cr-Commit-Position: refs/heads/master@{#433325}

[modify] https://crrev.com/7419dd4ce85ab76c88a8a64e7805a07eb9dd7790/chrome/browser/media/router/presentation_service_delegate_impl.cc

Status: Fixed (was: Available)

Comment 4 by mfo...@chromium.org, Mar 24 2017

Labels: -PresentationAPI

Sign in to add a comment