On multi-display environment, sometimes notification doesn't popup in non-primary display. This is due to the bug of this code: https://cs.chromium.org/chromium/src/ui/message_center/views/message_popup_collection.cc?rcl=0&l=179 Even on non-primary display, the vertical geometry is calculated based on the primary display. And it sometimes prevents notification from popping up. Context: https://bugs.chromium.org/p/chromium/issues/detail?id=661723#c9
Patch: http://crrev.com/2472233002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6171d1a24ab95e88598cbd499cfd908b8819ecba commit 6171d1a24ab95e88598cbd499cfd908b8819ecba Author: yoshiki <yoshiki@chromium.org> Date: Sat Nov 05 02:03:13 2016 Fix a bug of PopupAlignmentDelegate on non-primary display Previously, PopupAlignmentDelegate assumed the display's y-axis origin is 0. But it is not true in case of non-primary display which is not vertically aligned with the primary display. This patch makes PopupAlignmentDelegate consider such a non-primary display and fixes the issue. BUG= 662198 TEST=none Review-Url: https://codereview.chromium.org/2472233002 Cr-Commit-Position: refs/heads/master@{#430126} [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ash/common/system/web_notification/ash_popup_alignment_delegate.cc [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ash/common/system/web_notification/ash_popup_alignment_delegate.h [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ash/system/web_notification/web_notification_tray_unittest.cc [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ui/message_center/views/desktop_popup_alignment_delegate.cc [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ui/message_center/views/desktop_popup_alignment_delegate.h [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ui/message_center/views/message_popup_collection.cc [modify] https://crrev.com/6171d1a24ab95e88598cbd499cfd908b8819ecba/ui/message_center/views/popup_alignment_delegate.h
Comment 1 by yoshiki@chromium.org
, Nov 4 2016