Ignore 1xx (informational) HTTP status codes in HTTP/2. |
|||||||
Issue descriptionWith a status 1xx response, the client is supposed to keep on reading headers until it gets a set of headers with a non-1xx response. This works for HTTP, but not HTTP2, where we treat the second set of headers as a trailer, and return an error after that, as we don't expect body data after the trailers. I suspect we do the same for QUIC, but haven't verified it. Here's a sample H2 site that Chrome fails to load (Edge apparently handles it, haven't tested it): https://nghttp2.org/?103-eh There's some discussion of using a 103 status code to return link rel hints. Regardless of whether that pans out or not, should we support 100 responses over HTTP2/QUIC?
,
Nov 14 2016
Yeah this is probably something which should be done eventually. Not sure how important it is thought.
,
Nov 14 2016
Probably pretty low importance, unless other browsers are doing / start doing something that encourages HTTP/2 sites to use 100 status codes.
,
Nov 15 2016
firefox handles this correctly along with edge. The 103 change is being seriously considered as standards track, would hate to see that held back by a chrome bug.
,
Nov 15 2016
Re #4: Thank you for the heads up. Bumping priority accordingly.
,
Nov 17 2016
,
Nov 30 2016
Issue 669820 has been merged into this issue.
,
Nov 30 2016
,
Dec 5 2016
,
Dec 5 2016
Since this issue is focused on ignoring 1xx headers vs choking on them (and not so much on actually acting on 103 Early Hints), I am changing title of this issue to reflect that, and filing issue 671310, with lower priority, for acting on 103 Early Hints.
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9f762a0a84c859d1e57352637d4a06e1b2b4081 commit c9f762a0a84c859d1e57352637d4a06e1b2b4081 Author: bnc <bnc@chromium.org> Date: Tue Dec 06 20:38:23 2016 Ignore 1xx informational headers. Also correct response headers in a number of pre-existing unittests: status text is not allowed in HTTP/2. BUG= 662197 Review-Url: https://codereview.chromium.org/2555563003 Cr-Commit-Position: refs/heads/master@{#436701} [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_network_transaction_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_stream.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_stream.h [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_stream_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_test_util_common.cc
,
Dec 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9f762a0a84c859d1e57352637d4a06e1b2b4081 commit c9f762a0a84c859d1e57352637d4a06e1b2b4081 Author: bnc <bnc@chromium.org> Date: Tue Dec 06 20:38:23 2016 Ignore 1xx informational headers. Also correct response headers in a number of pre-existing unittests: status text is not allowed in HTTP/2. BUG= 662197 Review-Url: https://codereview.chromium.org/2555563003 Cr-Commit-Position: refs/heads/master@{#436701} [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_network_transaction_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_stream.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_stream.h [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_stream_unittest.cc [modify] https://crrev.com/c9f762a0a84c859d1e57352637d4a06e1b2b4081/net/spdy/spdy_test_util_common.cc
,
Dec 6 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mmenke@chromium.org
, Nov 14 2016