New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662189 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

servo v4 & servo_micro can't flash EC

Project Member Reported by aaboagye@chromium.org, Nov 3 2016

Issue description


(cr) (fix-mkbp-mutex) aaboagye@lithium ~/trunk/src/platform/ec $ ./util/flash_ec --board kevin
INFO: Using ec image : /mnt/host/source/src/platform/ec/build/kevin/ec.bin
INFO: ec UART pty : /dev/pts/37
Problem with ['dev_mode', 'ec_uart_baudrate', 'ec_uart_en', 'ec_uart_parity', 'jtag_buf_en', 'jtag_buf_on_flex_en'] :: No control named "ec_uart_baudrate"

Looks like we're missing the following controls:

dev_mode
ec_uart_baudrite
ec_uart_en
ec_uart_parity
jtag_buf_en
jtag_buf_on_flex_en

There might be more. I'll need to check flash_ec at some point.
 
Note that jtag_buf_on_flex_en doesn't exist because there is no buf_on_flex component on servo micro. 
Cc: dhend...@chromium.org
flash_ec needs to be modified to use different commands for servo_micro as most of those controls aren't relevant. 

Comment 3 by autumn@chromium.org, Nov 16 2016

What are the next steps here? 

Comment 4 by autumn@chromium.org, Nov 16 2016

Cc: haoweiw@chromium.org jrbarnette@chromium.org
+ Richard  / Haowei - does this block lab deployments? 
Re #4, it will for DUTs that support firmware repair.

Next steps are to refactor flash_ec to use the right controls. (need to find out what those controls are though...)

Comment 6 by dshi@chromium.org, Nov 29 2016

Re #5

who should own this work?
I'm thinking Nick/Aseda are best suited for this.
Owner: aaboagye@chromium.org
assigning to aaboagye@, please update if needed! 
Labels: -Pri-3 Pri-2
Status: Started (was: Untriaged)
Embarking on a little flash_ec refactor.
This CL will add the concept of a "servo type" to the flash_ec script.

https://chromium-review.googlesource.com/c/503475/
Status: Fixed (was: Started)
servo micro support was added with  issue 740026 . Flashing the EC with servo v4 (with those that support it) should work as well.

One thing that doesn't work is a servo micro behind a servo v4. I thought that this was the lab set up. Is that still true?
It is. On servo startup there's discovery code to find a servo micro behind a servo v4, as well as for CCD (which will probably also hit this problem). 

It may be that a "flashrom_serialno" or "dut_servo_serialno" dut-control should be set up there.
Okay, thanks for the confirmation. I prefer the former. Filed  issue 747112  for this follow up work.

Sign in to add a comment