New issue
Advanced search Search tips

Issue 662188 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::IntRect::uniteEvenIfEmpty

Project Member Reported by ClusterFuzz, Nov 3 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4973370014957568

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::uniteEvenIfEmpty
  blink::Region::unite
  blink::ScrollingCoordinator::computeShouldHandleScrollGestureOnMainThreadRegion
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=419707:419720

Minimized Testcase (0.36 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95nXdERBn0ytEl8dt54qG1JiZ2qr9NdbUrpzUJCzF3xFD5lqjx8g1Oy1ZP9QbxpE4EwrR0YSFhvcsyIiy8iuA0H-5Vjq3_Z2WnKIIW3-ew5XOVcuFUm6hGYV8-sgUzLV74_JRwx_dpOSN5LyySjO8z15eWrog?testcase_id=4973370014957568

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Labels: Test-Predator-Wrong-CLs
Components: Blink>Scroll
Cc: bokan@chromium.org
Owner: ymalik@chromium.org
Status: Assigned (was: Untriaged)
ymalik@ are you able to fix this? I'm guessing this code was added in: https://chromium.googlesource.com/chromium/src/+/c0cbafaf65dc4fc0ee22df128e71d9b97125123f%5E%21/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

miletus@ is no longer working on chromium.
Labels: Hotlist-Input-Dev

Comment 5 by ymalik@chromium.org, Nov 15 2016

Cc: skobes@chromium.org
Owner: bokan@chromium.org
There's a class Integer-overflow bugs https://bugs.chromium.org/p/chromium/issues/list?can=2&q=Integer-overflow+in+blink there should probably be a generic way to handle these cases.
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by bokan@chromium.org, Nov 28 2016

Status: WontFix (was: Assigned)
The test case contains overflowing integers. If anything this should be fixed in the parser but I believe the consensus (see  issue 634803 ) is that we WontFix overflow issues like this in Blink.
Project Member

Comment 8 by ClusterFuzz, Feb 1 2017

ClusterFuzz has detected this issue as fixed in range 446721:447186.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4973370014957568

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntRect::uniteEvenIfEmpty
  blink::Region::unite
  blink::ScrollingCoordinator::computeShouldHandleScrollGestureOnMainThreadRegion
  
Sanitizer: undefined (UBSAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=419707:419720
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_ubsan_chrome&range=446721:447186

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95nXdERBn0ytEl8dt54qG1JiZ2qr9NdbUrpzUJCzF3xFD5lqjx8g1Oy1ZP9QbxpE4EwrR0YSFhvcsyIiy8iuA0H-5Vjq3_Z2WnKIIW3-ew5XOVcuFUm6hGYV8-sgUzLV74_JRwx_dpOSN5LyySjO8z15eWrog?testcase_id=4973370014957568


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment