New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662186 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Popup blocked decoration has extra padding on the right

Project Member Reported by spqc...@chromium.org, Nov 3 2016 
The popup decoration has an incorrect amount of padding to its right

The regression is caused by https://codereview.chromium.org/2471583002/
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2edc6f9145d91684f2151462fa20873c29b87b62

commit 2edc6f9145d91684f2151462fa20873c29b87b62
Author: spqchan <spqchan@chromium.org>
Date: Mon Nov 14 19:47:49 2016

[Mac] Hover/Pressed background for the Omnibox decorations

- Added tracking areas for mouse interactive decorations
- Adjusted "popup blocker" bubble so that it has the right spacing for the background

BUG= 588377 ,  662186 

Review-Url: https://codereview.chromium.org/2478673002
Cr-Commit-Position: refs/heads/master@{#431908}

[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_unittest.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.h
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
[modify] https://crrev.com/2edc6f9145d91684f2151462fa20873c29b87b62/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 2 by spqc...@chromium.org, Nov 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment