New issue
Advanced search Search tips

Issue 662182 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 643885
issue 660179



Sign in to add a comment

Have bot_update return a list of files that changed from the applied patch.

Project Member Reported by d...@chromium.org, Nov 3 2016

Issue description

Currently, bot_update returns information about the checkout. This should be augmented with the list of paths that changed when the patch(es) applied. This can then be used by recipes to determine if they should perform various steps.
 

Comment 1 by d...@chromium.org, Nov 3 2016

Components: Infra>Platform>Recipes
Labels: -Pri-3 Pri-1
Cc: phajdan@google.com
Just checking: are you aware of tryserver.get_files_affected_by_patch ?

Comment 3 by d...@chromium.org, Nov 4 2016

Yeah. That function performs a "git diff", which is redundant with bot_update simply declaring which files are affected as part of its operation. The latter is preferable because:
- bot_update already knows this information, since it's the entity that's doing the patching.
- the affected files would show up in the bot_update JSON response, which is useful for understanding things.

If "bot_update" wants to use "git diff" to figure out what changed, that's fine, but I think it's bot_update's responsibility.
Labels: Pri-2
Status: Available (was: Untriaged)
This has been listed as untriaged for over two weeks. Marking available.

Since the priority is P-1, dropping it.

If you disagree with either of these actions (bulk edit), please fix.
Cc: -phajdan@google.com ehmaldonado@chromium.org
+Edward: since you've moved this feature to gclient, is it feasible to somehow expose this back to bot_update?
Cc: -ehmaldonado@chromium.org aga...@chromium.org
Owner: ehmaldonado@chromium.org
+agable.
I'll take a look once I finished moving it to gclient.
Status: Assigned (was: Available)
Status: Available (was: Assigned)
Cc: iannu...@google.com

Sign in to add a comment