Have bot_update return a list of files that changed from the applied patch. |
||||||||
Issue descriptionCurrently, bot_update returns information about the checkout. This should be augmented with the list of paths that changed when the patch(es) applied. This can then be used by recipes to determine if they should perform various steps.
,
Nov 4 2016
Just checking: are you aware of tryserver.get_files_affected_by_patch ?
,
Nov 4 2016
Yeah. That function performs a "git diff", which is redundant with bot_update simply declaring which files are affected as part of its operation. The latter is preferable because: - bot_update already knows this information, since it's the entity that's doing the patching. - the affected files would show up in the bot_update JSON response, which is useful for understanding things. If "bot_update" wants to use "git diff" to figure out what changed, that's fine, but I think it's bot_update's responsibility.
,
Jan 18 2017
This has been listed as untriaged for over two weeks. Marking available. Since the priority is P-1, dropping it. If you disagree with either of these actions (bulk edit), please fix.
,
Apr 28 2018
+Edward: since you've moved this feature to gclient, is it feasible to somehow expose this back to bot_update?
,
Apr 30 2018
+agable. I'll take a look once I finished moving it to gclient.
,
Aug 1
,
Sep 24
,
Oct 19
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by d...@chromium.org
, Nov 3 2016Labels: -Pri-3 Pri-1