DCHECK hit when opening chrome while signed in with a work account |
|||
Issue description[FATAL:ntp_snippets_service.cc(1080)] Check failed: IsCategoryStatusAvailable(content.status) ntp_snippets::NTPSnippetsService::NotifyNewSuggestions(ntp_snippets::Category) ntp_snippets_service.cc:1080 ntp_snippets::NTPSnippetsService::FinishInitialization() ntp_snippets_service.cc:994 ntp_snippets::NTPSnippetsService::OnDatabaseLoaded() ntp_snippets_service.cc:640 Repro: - Use a DEBUG build - Sign out, or sign in with a regular account - Obtain snippets - Sign in with work account - Kill and reopen Chrome => Crash I didn't look too much into it, but I think what happens is: We disable Articles for work accounts, but we have some remaining in the database, and when trying to add them to an explicitly disabled category we hit the DCHECK.
,
Nov 4 2016
I had a quick look and it seems the CHECK has been in there before. I believe this is not a real problem for opt-builds but we need to verify. @Marc: A quick fix for the particular problem (which should be also easy to merge), would simply to not notify about new suggestions for categories which are not available. For the proper fix, I'd like to clean up the logic inside NTPSnippetsService::OnFetchFinished() more and also propagate errors from the snippets fetcher so that we know how to handle empty results. With that, we can better separate category handling from suggestions handling and could simply drop suggestions from disabled categories.
,
Nov 14 2016
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb76bb12a9fa5ee0024dc92d32de3c2a0e8c8e46 commit fb76bb12a9fa5ee0024dc92d32de3c2a0e8c8e46 Author: treib <treib@chromium.org> Date: Tue Nov 15 11:34:57 2016 [NTP Snippets] Don't notify about new suggestion when in a not-available state BUG= 662179 Review-Url: https://codereview.chromium.org/2496163002 Cr-Commit-Position: refs/heads/master@{#432165} [modify] https://crrev.com/fb76bb12a9fa5ee0024dc92d32de3c2a0e8c8e46/components/ntp_snippets/remote/remote_suggestions_provider.cc [modify] https://crrev.com/fb76bb12a9fa5ee0024dc92d32de3c2a0e8c8e46/components/ntp_snippets/remote/remote_suggestions_provider.h [modify] https://crrev.com/fb76bb12a9fa5ee0024dc92d32de3c2a0e8c8e46/components/ntp_snippets/remote/remote_suggestions_provider_unittest.cc
,
Nov 15 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by fi...@chromium.org
, Nov 4 2016