New issue
Advanced search Search tips

Issue 662169 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Upload credit card save footer can appear in local credit card save bubble

Project Member Reported by jsaul@google.com, Nov 3 2016

Issue description

(See screenshot)

Version: 54.0.2840.71, but seen in the past as well
OS: Mac

Not 100% certain, but I believe the reproduction steps are:

1) Do something to offer Server credit card save
2) Do something to offer Local credit card save (same window (same tab?))
3) The server save footer with ToS links appears with the local save bubble, which should not happen

 
Components: UI>Browser>Autofill>Payments
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32f5238cedacdaacd30b01617814494f3a461d75

commit 32f5238cedacdaacd30b01617814494f3a461d75
Author: jdonnelly <jdonnelly@chromium.org>
Date: Tue Nov 08 18:43:38 2016

Remove legal messages from save card bubble before offering local save.

Before this change, if upload is offered and then local save is offered,
the legal messages associated with the upload are still present and
incorrectly shown to the user for the local save.

BUG= 662169 

Review-Url: https://codereview.chromium.org/2488743002
Cr-Commit-Position: refs/heads/master@{#430669}

[modify] https://crrev.com/32f5238cedacdaacd30b01617814494f3a461d75/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/32f5238cedacdaacd30b01617814494f3a461d75/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment