"WebNavigationApiTest.UserAction" is flaky |
|||||
Issue description"WebNavigationApiTest.UserAction" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9XZWJOYXZpZ2F0aW9uQXBpVGVzdC5Vc2VyQWN0aW9uDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Nov 4 2016
Maybe related to Issue 660288 Disabling the test on Win
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b59038fb0941969065252435c9ea041df45e8532 commit b59038fb0941969065252435c9ea041df45e8532 Author: tapted <tapted@chromium.org> Date: Fri Nov 04 05:31:05 2016 Disable Flaky WebNavigationApiTest.UserAction on Windows. BUG=662160 TBR=nasko@chromium.org Review-Url: https://codereview.chromium.org/2479733003 Cr-Commit-Position: refs/heads/master@{#429795} [modify] https://crrev.com/b59038fb0941969065252435c9ea041df45e8532/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Nov 4 2016
,
Jul 13 2017
Ping. Is this bug still in someone's queue? One recent flake: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.12%20Tests/builds/2718
,
Jul 13 2017
Probably worth considering to disable on Mac as well: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/15188
,
Aug 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f commit 2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f Author: Nasko Oskov <nasko@chromium.org> Date: Thu Aug 03 19:38:43 2017 Enable WebNavigationApiTest.UserAction Bug: 662160 Change-Id: If252b4f8765eb70218f6c89d8794c05566700fbe Reviewed-on: https://chromium-review.googlesource.com/600768 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#491817} [modify] https://crrev.com/2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5769cefdcb9f8a47e9edc90b9f1e7b76c813b6bb commit 5769cefdcb9f8a47e9edc90b9f1e7b76c813b6bb Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Aug 04 11:50:06 2017 Revert "Enable WebNavigationApiTest.UserAction" This reverts commit 2c3ec3ced96f6050c1bbcc0c4a8b9ebc12917a7f. Reason for revert: still failing (https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/27201) [ RUN ] WebNavigationApiTest.UserAction [5936:1628:0804/040823.764:WARNING:chrome_browser_main_win.cc(483)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=WebNavigationApiTest.UserAction --single_process --test-launcher-bot-mode --test-launcher-summary-output="e:\b\s\w\iou7dp23\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4492_8435\d4492_12222" --disable-offline-auto-reload --disable-renderer-backgrounding --no-first-run --no-default-browser-check --enable-logging=stderr --safebrowsing-disable-auto-update --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --allow-legacy-extension-manifests --disable-features=NetworkPrediction --flag-switches-begin --flag-switches-end --restore-last-session about:blank [5936:1628:0804/040824.460:WARNING:render_frame_host_impl.cc(2614)] OnDidStopLoading was called twice. [5936:1628:0804/040824.539:INFO:CONSOLE(0)] "[FAIL] userAction: Received unexpected event 'onCreatedNavigationTarget':{"sourceFrameId":1,"sourceProcessId":1,"sourceTabId":0,"tabId":1,"timeStamp":0,"url":"chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/b.html"} Error at Object.handleRequest (extensions::binding:64:27) at Object.<anonymous> (extensions::binding:374:32) at captureEvent (chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/_test_resources/api_test/webnavigation/framework.js:194:17) at chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/_test_resources/api_test/webnavigation/framework.js:223:5 at EventImpl.dispatchToListener (extensions::event_bindings:403:22) at Event.publicClassPrototype.(anonymous function) [as dispatchToListener] (extensions::utils:140:26) at EventImpl.dispatch_ (extensions::event_bindings:387:35) at dispatchArgs (extensions::event_bindings:260:26) at dispatchEvent (extensions::event_bindings:269:7)", source: chrome-extension://idlghkhmcoiheemhcoibdoomgdknhjdi/test_userAction.html (0) ../../chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc(537): error: Value of: catcher.GetNextResult() Actual: false Expected: true Failed 1 of 1 tests Original change's description: > Enable WebNavigationApiTest.UserAction > > Bug: 662160 > Change-Id: If252b4f8765eb70218f6c89d8794c05566700fbe > Reviewed-on: https://chromium-review.googlesource.com/600768 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491817} TBR=nasko@chromium.org,alexmos@chromium.org Change-Id: Ieeabb0b39759aa8b94916d7c10b3c867d106a142 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 662160 Reviewed-on: https://chromium-review.googlesource.com/602147 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#491995} [modify] https://crrev.com/5769cefdcb9f8a47e9edc90b9f1e7b76c813b6bb/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98cfabe9418bb39ec82ce941432303e302a10463 commit 98cfabe9418bb39ec82ce941432303e302a10463 Author: Nasko Oskov <nasko@chromium.org> Date: Fri Jul 27 22:36:30 2018 Enable WebNavigationApiTest.UserAction test. There have been various fixes in navigation code that have helped deflake webNavigationApi tests. The goal of this CL is to enable the WebNavigationApiTest.UserAction test and see if it has benefited from these fixes and is no longer flaky. Bug: 662160 Change-Id: Ia463d32f425b9e366c5879d4f297a521c8c28260 Reviewed-on: https://chromium-review.googlesource.com/1153394 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#578835} [modify] https://crrev.com/98cfabe9418bb39ec82ce941432303e302a10463/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Jul 30
Issue 868921 has been merged into this issue.
,
Jul 30
In this latest iteration of trying to enable it, it fails with difference in source process id. I think I have an idea of what might be causing it and will put up a CL with change for this in a bit.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbabfa4fc9d13342562a1f252376fcbba0cfa880 commit bbabfa4fc9d13342562a1f252376fcbba0cfa880 Author: Peter Boström <pbos@chromium.org> Date: Mon Jul 30 17:37:27 2018 Revert "Enable WebNavigationApiTest.UserAction test." This reverts commit 98cfabe9418bb39ec82ce941432303e302a10463. Reason for revert: Still reporting as flaky. Bug: chromium:868921 , chromium:662160 Original change's description: > Enable WebNavigationApiTest.UserAction test. > > There have been various fixes in navigation code that have helped deflake > webNavigationApi tests. The goal of this CL is to enable the > WebNavigationApiTest.UserAction test and see if it has benefited from > these fixes and is no longer flaky. > > Bug: 662160 > Change-Id: Ia463d32f425b9e366c5879d4f297a521c8c28260 > Reviewed-on: https://chromium-review.googlesource.com/1153394 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578835} TBR=nasko@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 662160 Change-Id: I57be2c1d1224720820efeb0204950b15f75d6731 Reviewed-on: https://chromium-review.googlesource.com/1155072 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#579080} [modify] https://crrev.com/bbabfa4fc9d13342562a1f252376fcbba0cfa880/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78510396086cc117c327ce5bf2f41d75a7e3e2a3 commit 78510396086cc117c327ce5bf2f41d75a7e3e2a3 Author: Nasko Oskov <nasko@chromium.org> Date: Thu Aug 02 01:19:50 2018 Update WebNavigationApiTest.UserAction to wait for navigation. The WebNavigationApiTest.UserAction loads a page with has a subframe in a different site than the main frame. Since the main page is an extension URL, those will get isolated in separate processes. The test checks that a context menu in the subframe, which opens a link in a new tab results in the correct event for the webNavigation API. However, since it doesn't wait for the subframe navigation to complete, the context menu creation can incorrectly capture the parent process id instead of the subframe process id. This is timing dependent, which leads to flakiness in the test. This CL adds an explicit observer for the subframe navigation and updates the test expectation to reflect the fact that the subframe is in a separate process than the parent. Bug: 662160 Change-Id: I40efc406818f572243720d8feaff2dd597262a5d Reviewed-on: https://chromium-review.googlesource.com/1155255 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580022} [modify] https://crrev.com/78510396086cc117c327ce5bf2f41d75a7e3e2a3/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc [modify] https://crrev.com/78510396086cc117c327ce5bf2f41d75a7e3e2a3/chrome/test/data/extensions/api_test/webnavigation/userAction/test_userAction.js
,
Aug 2
Detected 3 new flakes for test/step "WebNavigationApiTest.UserAction". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9XZWJOYXZpZ2F0aW9uQXBpVGVzdC5Vc2VyQWN0aW9uDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Aug 2
I will put up a patch to disable the test on Windows instead of reverting the patch in c#13, which adds an improvement to the test and improves its non-flakiness on other platforms.
,
Aug 2
CL to disable on Windows - https://chromium-review.googlesource.com/c/chromium/src/+/1160586
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2318e91b488de9dac1dc057fdfe34feab82e6f86 commit 2318e91b488de9dac1dc057fdfe34feab82e6f86 Author: Nasko Oskov <nasko@chromium.org> Date: Thu Aug 02 14:56:34 2018 Disable WebNavigationApiTest.UserAction on Windows due to flakiness. TBR=alexmos@chromium.org Bug: 662160 Change-Id: Ice66d0146daf565cf0119a040175641e3b6af791 Reviewed-on: https://chromium-review.googlesource.com/1160586 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580180} [modify] https://crrev.com/2318e91b488de9dac1dc057fdfe34feab82e6f86/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
,
Aug 2
Dropping sheriff label as the test is disabled and under investigation |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tapted@chromium.org
, Nov 4 2016