New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662157 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 672583



Sign in to add a comment

Decide what to do when we have !=1 (0 or >1) IMEDrivers.

Project Member Reported by moshayedi@chromium.org, Nov 3 2016

Issue description

In ui::IMEServerImpl we assume we have exactly one service providing the "ime:ime_driver" capability. What should we do if this is not the case?
 
Blocking: 672583
Labels: -Pri-1 Pri-2
Labels: Pri-3
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1340ff2da37b5fcd669e08842cea9223b325a873

commit 1340ff2da37b5fcd669e08842cea9223b325a873
Author: sky <sky@chromium.org>
Date: Fri Jan 20 21:30:53 2017

mash: Makes mash and service:ui not establish outgoing connections

The ui service was connecting to chrome for the ime driver. As the ui
service is a singleton and chrome isn't, this triggered launching
another process of chrome, which we don't want. Turns out having ui
connect to chrome for the ime driver is unnecessary as chrome already
does this. So, removing the code.

Mash was connecting to the chrome for the keyboard service. This is
also problematic for similar reasons, so removing it too. Filed bug
to have chrome register keyboard with mash.

BUG= 664267 , 662157 , 664264 , 683192 , 683289 
TEST=none
R=moshayedi@chromium.org

Review-Url: https://codereview.chromium.org/2645683007
Cr-Commit-Position: refs/heads/master@{#445172}

[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/BUILD.gn
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/ash/mus/keyboard_ui_mus.cc
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/BUILD.gn
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.cc
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/ime/ime_server_impl.h
[modify] https://crrev.com/1340ff2da37b5fcd669e08842cea9223b325a873/services/ui/manifest.json

Status: WontFix (was: Assigned)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment